Changeset 232748 in webkit

Timestamp:

Jun 12, 2018 4:40:17 AM (6 years ago)

Author:

clopez@igalia.com

Message:

[JSCOnly] Add a MIPS32el JSCOnly EWS
​https://bugs.webkit.org/show_bug.cgi?id=186523

Reviewed by Michael Catanzaro.

Add a new jsc-mips-ews queue that will execute build-jsc for the jsc-only (Linux) port.
The worker(s) on this queue should be pre-configured to cross-build JSC for MIPS32el.

• QueueStatusServer/config/queues.py:
• QueueStatusServer/model/queues.py:

(Queue.display_name):

• Scripts/webkitpy/common/config/ews.json:
• Scripts/webkitpy/common/config/ports.py:

(DeprecatedPort.port):
(WpePort.run_webkit_tests_command):
(JscOnlyPort):
(JscOnlyPort.build_jsc_command):

• Scripts/webkitpy/common/config/ports_unittest.py:

(DeprecatedPortTest.test_wincairo_port):
(DeprecatedPortTest):
(DeprecatedPortTest.test_jsconly_port):

• Scripts/webkitpy/port/factory.py:

(PortFactory):

• Scripts/webkitpy/port/jsc_only.py: Added. Add a basic port definition. Required by the EWS tooling.

(JscOnlyPort):
(JscOnlyPort.init):

• Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:

(test_ews_name):

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• QueueStatusServer/config/queues.py (modified) (1 diff)
• QueueStatusServer/model/queues.py (modified) (1 diff)
• Scripts/webkitpy/common/config/ews.json (modified) (1 diff)
• Scripts/webkitpy/common/config/ports.py (modified) (2 diffs)
• Scripts/webkitpy/common/config/ports_unittest.py (modified) (1 diff)
• Scripts/webkitpy/port/factory.py (modified) (1 diff)
• Scripts/webkitpy/port/jsc_only.py (added)
• Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py (modified) (1 diff)

trunk/Tools/ChangeLog

@@ +1 @@
+2018-06-11  Carlos Alberto Lopez Perez  <clopez@igalia.com>
+
+        [JSCOnly] Add a MIPS32el JSCOnly EWS
+        https://bugs.webkit.org/show_bug.cgi?id=186523
+
+        Reviewed by Michael Catanzaro.
+
+        Add a new jsc-mips-ews queue that will execute build-jsc for the jsc-only (Linux) port.
+        The worker(s) on this queue should be pre-configured to cross-build JSC for MIPS32el.
+
+        * QueueStatusServer/config/queues.py:
+        * QueueStatusServer/model/queues.py:
+        (Queue.display_name):
+        * Scripts/webkitpy/common/config/ews.json:
+        * Scripts/webkitpy/common/config/ports.py:
+        (DeprecatedPort.port):
+        (WpePort.run_webkit_tests_command):
+        (JscOnlyPort):
+        (JscOnlyPort.build_jsc_command):
+        * Scripts/webkitpy/common/config/ports_unittest.py:
+        (DeprecatedPortTest.test_wincairo_port):
+        (DeprecatedPortTest):
+        (DeprecatedPortTest.test_jsconly_port):
+        * Scripts/webkitpy/port/factory.py:
+        (PortFactory):
+        * Scripts/webkitpy/port/jsc_only.py: Added. Add a basic port definition. Required by the EWS tooling.
+        (JscOnlyPort):
+        (JscOnlyPort.__init__):
+        * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
+        (test_ews_name):
+
 2018-06-12  Zan Dobersek  <zdobersek@igalia.com>
 

trunk/Tools/QueueStatusServer/config/queues.py

@@ -39 +39 @@
     "bindings-ews",
     "jsc-ews",
+    "jsc-mips-ews",
     "mac-ews",
     "mac-wk2-ews",

trunk/Tools/QueueStatusServer/model/queues.py

@@ -79 +79 @@
         display_name = display_name.replace("Ews", "EWS")
         display_name = display_name.replace("Ios", "iOS")
+        display_name = display_name.replace("JscOnly", "JSCOnly")
         display_name = display_name.replace("Jsc", "JSC")
         display_name = display_name.replace("Wpe", "WPE")

trunk/Tools/Scripts/webkitpy/common/config/ews.json

@@ -54 +54 @@
         "runTests": true
     },
+    "JSC MIPS32el EWS": {
+        "port": "jsc-only",
+        "name": "jsc-mips-ews",
+        "group": "jsc",
+        "runTests": false,
+        "watchers": [
+            "guijemont@igalia.com"
+        ]
+    },
     "Bindings EWS": {
         "port": "mac",

trunk/Tools/Scripts/webkitpy/common/config/ports.py

@@ -69 +69 @@
             "ios": IOSPort,
             "ios-simulator-wk2": IOSSimulatorWK2Port,
+            "jsc-only": JscOnlyPort,
             "mac": MacPort,
             "mac-wk2": MacWK2Port,
@@ -231 +232 @@
         command.append("--wpe")
         return command
+
+
+class JscOnlyPort(DeprecatedPort):
+    port_flag_name = "jsc-only"
+
+    def build_jsc_command(self, build_style=None):
+        command = self.script_shell_command("build-jsc")
+        return self._append_build_style_flag(command, build_style)

trunk/Tools/Scripts/webkitpy/common/config/ports_unittest.py

@@ -62 +62 @@
         self.assertEqual(WinCairoPort().build_webkit_command(), DeprecatedPort().script_shell_command("build-webkit") + ["--wincairo"])
         self.assertEqual(WinCairoPort().build_webkit_command(build_style="debug"), DeprecatedPort().script_shell_command("build-webkit") + ["--debug", "--wincairo"])
+
+    def test_jsconly_port(self):
+        self.assertEqual(JscOnlyPort().flag(), "--port=jsc-only")
+        self.assertEqual(JscOnlyPort().build_jsc_command(), DeprecatedPort().script_shell_command("build-jsc"))
+        self.assertEqual(JscOnlyPort().build_jsc_command(build_style="release"), DeprecatedPort().script_shell_command("build-jsc") + ["--release"])
+        self.assertEqual(JscOnlyPort().build_jsc_command(build_style="debug"), DeprecatedPort().script_shell_command("build-jsc") + ["--debug"])

trunk/Tools/Scripts/webkitpy/port/factory.py

@@ -92 +92 @@
         'ios_simulator.IOSSimulatorPort',
         'ios_device.IOSDevicePort',
+        'jsc_only.JscOnlyPort',
         'mac.MacPort',
         'mock_drt.MockDRTPort',

trunk/Tools/Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py

@@ -198 +198 @@
             'ios-sim-ews',
             'jsc-ews',
+            'jsc-mips-ews',
             'mac-32bit-ews',
             'mac-debug-ews',