Changeset 232855 in webkit

Timestamp:

Jun 14, 2018 2:44:01 PM (6 years ago)

Author:

commit-queue@webkit.org

Message:

[test262-runner] Improve displayed settings, use rel paths
​https://bugs.webkit.org/show_bug.cgi?id=186626

Patch by Leo Balter <Leo Balter> on 2018-06-14
Reviewed by Michael Saboff.

Use relative paths for the information printed in the settings summary after calling the Test262 Runner. This provides a cleaner summary that is easier to read and consume.

• Scripts/test262/Runner.pm:

(processCLI):
(getBuildPath):

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• Scripts/test262/Runner.pm (modified) (4 diffs)

trunk/Tools/ChangeLog

@@ +1 @@
+2018-06-14  Leo Balter  <leonardo.balter@gmail.com>
+
+        [test262-runner] Improve displayed settings, use rel paths
+        https://bugs.webkit.org/show_bug.cgi?id=186626
+
+        Reviewed by Michael Saboff.
+
+        Use relative paths for the information printed in the settings summary after calling the Test262 Runner. This provides a cleaner summary that is easier to read and consume.
+        * Scripts/test262/Runner.pm:
+        (processCLI):
+        (getBuildPath):
+
 2018-06-14  Leo Balter  <leonardo.balter@gmail.com>
 

trunk/Tools/Scripts/test262/Runner.pm

@@ -247 +247 @@
     $max_process ||= getProcesses();
 
-    print "\n-------------------------Settings------------------------\n"
-        . "Test262 Dir: $test262Dir\n"
-        . "JSC: $JSC\n"
+    print "\nSettings:\n"
+        . "Test262 Dir: " . abs2rel($test262Dir) . "\n"
+        . "JSC: " . abs2rel($JSC) . "\n"
         . "Child Processes: $max_process\n";
 
@@ -256 +256 @@
     print "Features to include: " . join(', ', @features) . "\n" if @features;
     print "Paths: " . join(', ', @cliTestDirs) . "\n" if @cliTestDirs;
-    print "Config file: $configFile\n" if $config;
-    print "Expectations file: $expectationsFile\n" if $expect;
-    print "Results file: $resultsFile\n" if $stats || $failingOnly;
+    print "Config file: " . abs2rel($configFile) . "\n" if $config;
+    print "Expectations file: " . abs2rel($expectationsFile) . "\n" if $expect;
+    print "Results file: ". abs2rel($resultsFile) . "\n" if $stats || $failingOnly;
 
     print "Running only the latest imported files\n" if $latestImport;
@@ -264 +264 @@
     print "Verbose mode\n" if $verbose;
 
-    print "--------------------------------------------------------\n\n";
+    print "---\n\n";
 }
 
@@ -530 +530 @@
         $jsc = $jscDir . '/bin/jsc' if (! -e $jsc);
 
-        # Sets the Env DYLD_FRAMEWORK_PATH
-        $DYLD_FRAMEWORK_PATH = dirname($jsc) if (-e $jsc);
+        # Sets the Env DYLD_FRAMEWORK_PATH, abs_path will remove any extra '/' character
+        $DYLD_FRAMEWORK_PATH = abs_path(dirname($jsc)) if (-e $jsc);
     }