Context Navigation

Changeset 232887 in webkit

Timestamp:

Jun 15, 2018 12:33:41 PM (6 years ago)

Author:

pvollan@apple.com

Message:

Crash in both StorageProcess and UIProcess when using custom WKWebsiteDataStores for data management.
<rdar://problem/41019893> and https://bugs.webkit.org/show_bug.cgi?id=186682

Patch by Brady Eidson <beidson@apple.com> on 2018-06-15
Reviewed by Chris Dumez.

(WebKit::StorageProcessProxy::didClose): Protect this and the process pool as the cleanup that follows

might cause either to get destroyed.

(WebKit::WebsiteDataStore::fetchDataAndApply): Protect the operating WebsiteDataStore while async operations

are in flight. Otherwise if the data store is destroyed, the SessionIDs for those operations will get
destroyed before they complete.

(WebKit::WebsiteDataStore::removeData): Ditto.

Location:

trunk/Source/WebKit

Files:

-                      r232886
+                      r232887
           destroyed before they complete.
         (WebKit::WebsiteDataStore::removeData): Ditto.
+-06-15  Per Arne Vollan  <pvollan@apple.com>
+        Unreviewed build fix after r232634.
+        * WebProcess/WebPage/DrawingArea.h:
+        * WebProcess/WebPage/DrawingArea.messages.in:
 -06-15  Per Arne Vollan  <pvollan@apple.com>

r230834	r232887
148	148	#endif
149	149
150		#if PLATFORM(MAC) && ~~__MAC_OS_X_VERSION_MIN_REQUIRED >= 101400~~
	150	#if PLATFORM(MAC) && ENABLE(WEBPROCESS_WINDOWSERVER_BLOCKING)
151	151	void displayWasRefreshed();
152	152	#endif

r230269	r232887
46	46	#endif
47	47
48		#if PLATFORM(MAC) && ~~__MAC_OS_X_VERSION_MIN_REQUIRED >= 101400~~
	48	#if PLATFORM(MAC) && ENABLE(WEBPROCESS_WINDOWSERVER_BLOCKING)
49	49	DisplayWasRefreshed()
50	50	#endif

Note: See TracChangeset for help on using the changeset viewer.