Changeset 232996 in webkit

Timestamp:

Jun 19, 2018 5:09:27 PM (6 years ago)

Author:

commit-queue@webkit.org

Message:

[test262-runner] Reduce flakiness of unit tests for the runner
​https://bugs.webkit.org/show_bug.cgi?id=186824

Patch by Leo Balter <Leo Balter> on 2018-06-19
Reviewed by Michael Saboff.

• Scripts/test262/Runner.pm:

(main):

• Scripts/webkitperl/test262_unittest/test262-runner-tests.pl:

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• Scripts/test262/Runner.pm (modified) (1 diff)
• Scripts/webkitperl/test262_unittest/test262-runner-tests.pl (modified) (2 diffs)

trunk/Tools/ChangeLog

@@ +1 @@
+2018-06-19  Leo Balter  <leonardo.balter@gmail.com>
+
+        [test262-runner] Reduce flakiness of unit tests for the runner
+        https://bugs.webkit.org/show_bug.cgi?id=186824
+
+        Reviewed by Michael Saboff.
+
+        * Scripts/test262/Runner.pm:
+        (main):
+        * Scripts/webkitperl/test262_unittest/test262-runner-tests.pl:
+
 2018-06-19  Leo Balter  <leonardo.balter@gmail.com>
 

trunk/Tools/Scripts/test262/Runner.pm

@@ -347 +347 @@
             # each child starts with a file;
             my $file = shift @files;
-            chomp $file;
             if ($file) {
+                chomp $file;
                 print $child "$file\n";
                 $activeChildren++;

trunk/Tools/Scripts/webkitperl/test262_unittest/test262-runner-tests.pl

@@ -48 +48 @@
 
 my $Bin = $FindBin::Bin;
-my $runner = abs_path("$Bin/../../test262-runner");
+my $runner = abs_path("$Bin/../../test262-runner -p 1");
 my $mockTest262 = abs_path("$Bin/fixtures");
 
@@ -134 +134 @@
     my $expectedExitCode = $testCase->{EXITSTATUS};
     my $testName =  $testCase->{TESTNAME} . " (exit code: $expectedExitCode)";
-    is($exitCode, $testCase->{EXITSTATUS}, $testName);
+    is($exitCode, $expectedExitCode, $testName);
 
     # Test the number of occurences of string "! NEW FAIL"