Changeset 232999 in webkit

Timestamp:

Jun 19, 2018 6:01:48 PM (6 years ago)

Author:

dino@apple.com

Message:

ARKit badge drop shadow updates its blur radius based on page zoom
​https://bugs.webkit.org/show_bug.cgi?id=186829
<rdar://problem/40738779>

Reviewed by Tim Horton.

We need to make sure the shadow blur radius takes into account the
current zoom. Thankfully, the GraphicsContext platform code already
does this, so just use it.

• rendering/RenderThemeIOS.mm:

(WebCore::RenderThemeIOS::paintSystemPreviewBadge):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• rendering/RenderThemeIOS.mm (modified) (2 diffs)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2018-06-19  Dean Jackson  <dino@apple.com>
+
+        ARKit badge drop shadow updates its blur radius based on page zoom
+        https://bugs.webkit.org/show_bug.cgi?id=186829
+        <rdar://problem/40738779>
+
+        Reviewed by Tim Horton.
+
+        We need to make sure the shadow blur radius takes into account the
+        current zoom. Thankfully, the GraphicsContext platform code already
+        does this, so just use it.
+
+        * rendering/RenderThemeIOS.mm:
+        (WebCore::RenderThemeIOS::paintSystemPreviewBadge):
+
 2018-06-19  Dean Jackson  <dino@apple.com>
 

trunk/Source/WebCore/rendering/RenderThemeIOS.mm

@@ -1857 +1857 @@
         return;
 
+    GraphicsContextStateSaver stateSaver(graphicsContext);
+
     CGContextRef ctx = graphicsContext.platformContext();
     if (!ctx)
@@ -1864 +1866 @@
 
     // Draw a drop shadow around the circle.
-    CGFloat shadowColorComponents[4] = { 0, 0, 0, 0.1 };
-    RetainPtr<CGColorRef> shadowColor = adoptCF(CGColorCreate(sRGBColorSpaceRef(), shadowColorComponents));
+    // Use the GraphicsContext function, because it calculates the blur radius in context space,
+    // rather than screen space.
+    Color shadowColor = Color { 0.f, 0.f, 0.f, 0.1f };
+    graphicsContext.setShadow(FloatSize { }, 16, shadowColor);
+
     // The circle must have an alpha channel value of 1 for the shadow color to appear.
     CGFloat circleColorComponents[4] = { 0, 0, 0, 1 };
     RetainPtr<CGColorRef> circleColor = adoptCF(CGColorCreate(sRGBColorSpaceRef(), circleColorComponents));
     CGContextSetFillColorWithColor(ctx, circleColor.get());
-    CGContextSetShadowWithColor(ctx, CGSizeZero, 16, shadowColor.get());
 
     // Clip out the circle to only show the shadow.