Changeset 233032 in webkit
- Timestamp:
- Jun 21, 2018 2:54:30 AM (6 years ago)
- Location:
- trunk
- Files:
-
- 4 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/LayoutTests/ChangeLog
r233031 r233032 1 2018-06-21 Fujii Hironori <Hironori.Fujii@sony.com> 2 3 [GTK] http/tests/misc/bubble-drag-events.html crashes 4 https://bugs.webkit.org/show_bug.cgi?id=182352 5 6 Reviewed by Carlos Garcia Campos. 7 8 * platform/gtk/TestExpectations: 9 Marked http/tests/misc/bubble-drag-events.html as [ Failure ] not 10 [ Failure Timeout Crash ]. 11 Unmarked http/tests/misc/cached-scripts.html. 12 1 13 2018-06-21 Zan Dobersek <zdobersek@igalia.com> 2 14 -
trunk/LayoutTests/platform/gtk/TestExpectations
r233017 r233032 1297 1297 webkit.org/b/186767 fast/hidpi/broken-image-icon-very-hidpi.html [ Crash Pass ] 1298 1298 1299 # This one crashes only on EWS.1300 webkit.org/b/186778 http/tests/misc/cached-scripts.html [ Crash Pass ]1301 1302 1299 webkit.org/b/186779 http/tests/security/sandboxed-iframe-DENIED-modals.html [ Crash Pass ] 1303 1300 … … 2663 2660 Bug(GTK) http/tests/security/drag-over-remote-content-iframe.html [ Failure ] 2664 2661 Bug(GTK) fast/events/drag-in-frames.html [ Failure Timeout ] 2665 webkit.org/b/182352 http/tests/misc/bubble-drag-events.html [ Failure Timeout Crash]2662 webkit.org/b/182352 http/tests/misc/bubble-drag-events.html [ Failure ] 2666 2663 2667 2664 # Dragging images and links results in a DataTransfer object containing a non-empty files array -
trunk/Source/WebKit/ChangeLog
r233025 r233032 1 2018-06-21 Fujii Hironori <Hironori.Fujii@sony.com> 2 3 [GTK] http/tests/misc/bubble-drag-events.html crashes 4 https://bugs.webkit.org/show_bug.cgi?id=182352 5 6 Reviewed by Carlos Garcia Campos. 7 8 PingLoad::didFinish was called twice if it is used with 9 NetworkDataTaskSoup. PingLoad is not a ref-counted object. It is 10 destructed when PingLoad::didFinish is called. 11 12 PingLoad::didReceiveChallenge calls the ChallengeCompletionHandler 13 with AuthenticationChallengeDisposition::Cancel to cancel the 14 challenge and calls PingLoad::didFinish. 15 16 NetworkDataTaskSoup::continueAuthenticate calls 17 didReceiveChallenge with a ChallengeCompletionHandler which calls 18 didCompleteWithError. PingLoad::didCompleteWithError calls 19 PingLoad::didFinish. 20 21 didCompleteWithError callback should not be called in the 22 ChallengeCompletionHandler. 23 24 * NetworkProcess/soup/NetworkDataTaskSoup.cpp: 25 (WebKit::NetworkDataTaskSoup::continueAuthenticate): Do not call 26 didFail() in the ChallengeCompletionHandler. Call 27 invalidateAndCancel() instead. 28 1 29 2018-06-20 Wenson Hsieh <wenson_hsieh@apple.com> 2 30 -
trunk/Source/WebKit/NetworkProcess/soup/NetworkDataTaskSoup.cpp
r231008 r233032 529 529 530 530 if (disposition == AuthenticationChallengeDisposition::Cancel) { 531 cancel(); 532 didFail(cancelledError(m_soupRequest.get())); 531 invalidateAndCancel(); 533 532 return; 534 533 }
Note: See TracChangeset
for help on using the changeset viewer.