Changeset 233033 in webkit


Ignore:
Timestamp:
Jun 21, 2018 3:14:55 AM (6 years ago)
Author:
Fujii Hironori
Message:

[GStreamer] ASSERTION FAILED: end.isValid() in PlatformTimeRanges::add
https://bugs.webkit.org/show_bug.cgi?id=186880

Reviewed by Xabier Rodriguez-Calvar.

Source/WebCore:

Bug 180253 has added assertions the arugments start and end is
valid MediaTime in PlatformTimeRanges::add. Since then, some
LayoutTests fail due to the assertion failure.

The invalid MediaTime is added into the PlatformTimeRanges in
MediaPlayerPrivateGStreamer::buffered. Before adding MediaTime,
original implementation checks MediaTime::operator bool() returns
true. But, this method returns true if the time value is invalid.
Then, PlatformTimeRanges::add is called with an invalid MediaTime.

No new tests (No behavior change).

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:

(WebCore::MediaPlayerPrivateGStreamer::buffered const): Check
maxTimeLoaded() is valid before adding to timeRanges.

LayoutTests:

  • platform/gtk/TestExpectations: Removed Crash marks of

compositing/geometry/clipped-video-controller.html,
fast/canvas/webgl/oes-texture-half-float-with-video.html,
fast/canvas/webgl/tex-image-and-sub-image-2d-with-video-rgb565.html,
fast/canvas/webgl/tex-image-and-sub-image-2d-with-video-rgba5551.html,
fast/canvas/webgl/tex-image-and-sub-image-2d-with-video.html,
fast/events/media-focus-in-standalone-media-document.html,
fullscreen/video-controls-timeline.html,
http/tests/appcache/video.html, and compositing/video/poster.html.

Location:
trunk
Files:
4 edited

Legend:

Unmodified
Added
Removed
  • trunk/LayoutTests/ChangeLog

    r233032 r233033  
     12018-06-21  Fujii Hironori  <Hironori.Fujii@sony.com>
     2
     3        [GStreamer] ASSERTION FAILED: end.isValid() in PlatformTimeRanges::add
     4        https://bugs.webkit.org/show_bug.cgi?id=186880
     5
     6        Reviewed by Xabier Rodriguez-Calvar.
     7
     8        * platform/gtk/TestExpectations: Removed Crash marks of
     9        compositing/geometry/clipped-video-controller.html,
     10        fast/canvas/webgl/oes-texture-half-float-with-video.html,
     11        fast/canvas/webgl/tex-image-and-sub-image-2d-with-video-rgb565.html,
     12        fast/canvas/webgl/tex-image-and-sub-image-2d-with-video-rgba5551.html,
     13        fast/canvas/webgl/tex-image-and-sub-image-2d-with-video.html,
     14        fast/events/media-focus-in-standalone-media-document.html,
     15        fullscreen/video-controls-timeline.html,
     16        http/tests/appcache/video.html, and compositing/video/poster.html.
     17
    1182018-06-21  Fujii Hironori  <Hironori.Fujii@sony.com>
    219
  • trunk/LayoutTests/platform/gtk/TestExpectations

    r233032 r233033  
    12851285webkit.org/b/185910 media/video-duration-known-after-eos.html [ Crash Pass ]
    12861286
    1287 webkit.org/b/180253 [ Debug ] compositing/geometry/clipped-video-controller.html [ Crash ]
    1288 webkit.org/b/180253 [ Debug ] fast/canvas/webgl/oes-texture-half-float-with-video.html [ Crash ]
    1289 webkit.org/b/180253 [ Debug ] fast/canvas/webgl/tex-image-and-sub-image-2d-with-video-rgb565.html [ Crash ]
    1290 webkit.org/b/180253 [ Debug ] fast/canvas/webgl/tex-image-and-sub-image-2d-with-video-rgba5551.html [ Crash ]
    1291 webkit.org/b/180253 [ Debug ] fast/canvas/webgl/tex-image-and-sub-image-2d-with-video.html [ Crash ]
    1292 webkit.org/b/180253 [ Debug ] fast/events/media-focus-in-standalone-media-document.html [ Crash ]
    1293 webkit.org/b/180253 [ Debug ] fullscreen/video-controls-timeline.html [ Crash ]
    1294 webkit.org/b/180253 [ Debug ] http/tests/appcache/video.html [ Crash ]
    1295 
    12961287# Crashes only when GNOME icon theme is not installed
    12971288webkit.org/b/186767 fast/hidpi/broken-image-icon-very-hidpi.html [ Crash Pass ]
     
    19291920webkit.org/b/183609 inspector/unit-tests/throttle.html [ Pass Failure ]
    19301921
    1931 # Crash is bug #180253
    1932 webkit.org/b/183214 compositing/video/poster.html [ Pass ImageOnlyFailure Crash ]
     1922webkit.org/b/183214 compositing/video/poster.html [ Pass ImageOnlyFailure ]
    19331923
    19341924webkit.org/b/183903 http/tests/media/video-buffered-range-contains-currentTime.html [ Crash Pass ]
  • trunk/Source/WebCore/ChangeLog

    r233029 r233033  
     12018-06-21  Fujii Hironori  <Hironori.Fujii@sony.com>
     2
     3        [GStreamer] ASSERTION FAILED: end.isValid() in PlatformTimeRanges::add
     4        https://bugs.webkit.org/show_bug.cgi?id=186880
     5
     6        Reviewed by Xabier Rodriguez-Calvar.
     7
     8        Bug 180253 has added assertions the arugments `start` and `end` is
     9        valid MediaTime in PlatformTimeRanges::add. Since then, some
     10        LayoutTests fail due to the assertion failure.
     11
     12        The invalid MediaTime is added into the PlatformTimeRanges in
     13        MediaPlayerPrivateGStreamer::buffered. Before adding MediaTime,
     14        original implementation checks MediaTime::operator bool() returns
     15        true. But, this method returns true if the time value is invalid.
     16        Then, PlatformTimeRanges::add is called with an invalid MediaTime.
     17
     18        No new tests (No behavior change).
     19
     20        * platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
     21        (WebCore::MediaPlayerPrivateGStreamer::buffered const): Check
     22        maxTimeLoaded() is valid before adding to `timeRanges`.
     23
    1242018-06-20  David Kilzer  <ddkilzer@apple.com>
    225
  • trunk/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp

    r232925 r233033  
    11131113    // been found.
    11141114    if (!timeRanges->length()) {
    1115         if (MediaTime loaded = maxTimeLoaded())
     1115        MediaTime loaded = maxTimeLoaded();
     1116        if (loaded.isValid() && loaded)
    11161117            timeRanges->add(MediaTime::zeroTime(), loaded);
    11171118    }
Note: See TracChangeset for help on using the changeset viewer.