Changeset 233080 in webkit
- Timestamp:
- Jun 22, 2018 8:43:45 AM (6 years ago)
- Location:
- trunk
- Files:
-
- 7 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/LayoutTests/ChangeLog
r233069 r233080 1 2018-06-22 Michael Catanzaro <mcatanzaro@igalia.com> 2 3 REGRESSION(r230950): [GTK] WebKit::CoordinatedBackingStoreTile::setBackBuffer(): WebKitWebProcess killed by SIGSEGV (ASSERTION FAILED: it != m_tiles.end()) 4 https://bugs.webkit.org/show_bug.cgi?id=186206 5 6 Unreviewed, remove crash expectations for crashes introduced by r230950. 7 8 * platform/gtk/TestExpectations: 9 1 10 2018-06-21 David Fenton <david_fenton@apple.com> 2 11 -
trunk/LayoutTests/platform/gtk/TestExpectations
r233033 r233080 1283 1283 webkit.org/b/185546 media/video-playbackrate.html [ Crash Pass ] 1284 1284 1285 webkit.org/b/185910 media/video-duration-known-after-eos.html [ Crash Pass ]1286 1287 1285 # Crashes only when GNOME icon theme is not installed 1288 1286 webkit.org/b/186767 fast/hidpi/broken-image-icon-very-hidpi.html [ Crash Pass ] … … 1616 1614 webkit.org/b/133866 media/media-controls-cancel-events.html [ Timeout Failure Pass ] 1617 1615 webkit.org/b/133867 webaudio/audioprocessingevent.html [ Failure Pass ] 1618 # Crash is webkit.org/b/186206 1619 webkit.org/b/133869 media/video-seek-after-end.html [ Failure Crash ] 1616 webkit.org/b/133869 media/video-seek-after-end.html [ Failure ] 1620 1617 1621 1618 # Crash is webkit.org/b/176802 -
trunk/Source/WebCore/ChangeLog
r233079 r233080 1 2018-06-22 Michael Catanzaro <mcatanzaro@igalia.com> 2 3 REGRESSION(r230950): [GTK] WebKit::CoordinatedBackingStoreTile::setBackBuffer(): WebKitWebProcess killed by SIGSEGV (ASSERTION FAILED: it != m_tiles.end()) 4 https://bugs.webkit.org/show_bug.cgi?id=186206 5 6 Unreviewed manual rollout of r230950 7 8 * platform/graphics/texmap/TextureMapperLayer.h: 9 * platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.cpp: 10 (WebCore::CoordinatedGraphicsLayer::shouldHaveBackingStore const): 11 1 12 2018-06-20 Darin Adler <darin@apple.com> 2 13 -
trunk/Source/WebCore/platform/graphics/texmap/TextureMapperLayer.h
r232613 r233080 89 89 void setContentsLayer(TextureMapperPlatformLayer*); 90 90 void setAnimations(const TextureMapperAnimations&); 91 const TextureMapperAnimations& animations() const { return m_animations; }92 91 void setBackingStore(TextureMapperBackingStore*); 93 92 -
trunk/Source/WebCore/platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.cpp
r230955 r233080 1085 1085 bool CoordinatedGraphicsLayer::shouldHaveBackingStore() const 1086 1086 { 1087 return drawsContent() && contentsAreVisible() && !m_size.isEmpty() 1088 && (!!opacity() || m_animations.hasActiveAnimationsOfType(AnimatedPropertyOpacity)); 1087 return drawsContent() && contentsAreVisible() && !m_size.isEmpty(); 1089 1088 } 1090 1089 -
trunk/Source/WebKit/ChangeLog
r233079 r233080 1 2018-06-22 Michael Catanzaro <mcatanzaro@igalia.com> 2 3 REGRESSION(r230950): [GTK] WebKit::CoordinatedBackingStoreTile::setBackBuffer(): WebKitWebProcess killed by SIGSEGV (ASSERTION FAILED: it != m_tiles.end()) 4 https://bugs.webkit.org/show_bug.cgi?id=186206 5 6 Unreviewed manual rollout of r230950 7 8 * Shared/CoordinatedGraphics/CoordinatedGraphicsScene.cpp: 9 (WebKit::layerShouldHaveBackingStore): 10 1 11 2018-06-20 Darin Adler <darin@apple.com> 2 12 -
trunk/Source/WebKit/Shared/CoordinatedGraphics/CoordinatedGraphicsScene.cpp
r230955 r233080 38 38 static bool layerShouldHaveBackingStore(TextureMapperLayer* layer) 39 39 { 40 return layer->drawsContent() && layer->contentsAreVisible() && !layer->size().isEmpty() 41 && (!!layer->opacity() || layer->animations().hasActiveAnimationsOfType(AnimatedPropertyOpacity)); 40 return layer->drawsContent() && layer->contentsAreVisible() && !layer->size().isEmpty(); 42 41 } 43 42
Note: See TracChangeset
for help on using the changeset viewer.