Changeset 233080 in webkit


Ignore:
Timestamp:
Jun 22, 2018 8:43:45 AM (6 years ago)
Author:
Michael Catanzaro
Message:

REGRESSION(r230950): [GTK] WebKit::CoordinatedBackingStoreTile::setBackBuffer(): WebKitWebProcess killed by SIGSEGV (ASSERTION FAILED: it != m_tiles.end())
https://bugs.webkit.org/show_bug.cgi?id=186206

Source/WebCore:

Unreviewed manual rollout of r230950

  • platform/graphics/texmap/TextureMapperLayer.h:
  • platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.cpp:

(WebCore::CoordinatedGraphicsLayer::shouldHaveBackingStore const):

Source/WebKit:

Unreviewed manual rollout of r230950

  • Shared/CoordinatedGraphics/CoordinatedGraphicsScene.cpp:

(WebKit::layerShouldHaveBackingStore):

LayoutTests:

Unreviewed, remove crash expectations for crashes introduced by r230950.

  • platform/gtk/TestExpectations:
Location:
trunk
Files:
7 edited

Legend:

Unmodified
Added
Removed
  • trunk/LayoutTests/ChangeLog

    r233069 r233080  
     12018-06-22  Michael Catanzaro  <mcatanzaro@igalia.com>
     2
     3        REGRESSION(r230950): [GTK] WebKit::CoordinatedBackingStoreTile::setBackBuffer(): WebKitWebProcess killed by SIGSEGV (ASSERTION FAILED: it != m_tiles.end())
     4        https://bugs.webkit.org/show_bug.cgi?id=186206
     5
     6        Unreviewed, remove crash expectations for crashes introduced by r230950.
     7
     8        * platform/gtk/TestExpectations:
     9
    1102018-06-21  David Fenton  <david_fenton@apple.com>
    211
  • trunk/LayoutTests/platform/gtk/TestExpectations

    r233033 r233080  
    12831283webkit.org/b/185546 media/video-playbackrate.html [ Crash Pass ]
    12841284
    1285 webkit.org/b/185910 media/video-duration-known-after-eos.html [ Crash Pass ]
    1286 
    12871285# Crashes only when GNOME icon theme is not installed
    12881286webkit.org/b/186767 fast/hidpi/broken-image-icon-very-hidpi.html [ Crash Pass ]
     
    16161614webkit.org/b/133866 media/media-controls-cancel-events.html [ Timeout Failure Pass ]
    16171615webkit.org/b/133867 webaudio/audioprocessingevent.html [ Failure Pass ]
    1618 # Crash is webkit.org/b/186206
    1619 webkit.org/b/133869 media/video-seek-after-end.html [ Failure Crash ]
     1616webkit.org/b/133869 media/video-seek-after-end.html [ Failure ]
    16201617
    16211618# Crash is webkit.org/b/176802
  • trunk/Source/WebCore/ChangeLog

    r233079 r233080  
     12018-06-22  Michael Catanzaro  <mcatanzaro@igalia.com>
     2
     3        REGRESSION(r230950): [GTK] WebKit::CoordinatedBackingStoreTile::setBackBuffer(): WebKitWebProcess killed by SIGSEGV (ASSERTION FAILED: it != m_tiles.end())
     4        https://bugs.webkit.org/show_bug.cgi?id=186206
     5
     6        Unreviewed manual rollout of r230950
     7
     8        * platform/graphics/texmap/TextureMapperLayer.h:
     9        * platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.cpp:
     10        (WebCore::CoordinatedGraphicsLayer::shouldHaveBackingStore const):
     11
    1122018-06-20  Darin Adler  <darin@apple.com>
    213
  • trunk/Source/WebCore/platform/graphics/texmap/TextureMapperLayer.h

    r232613 r233080  
    8989    void setContentsLayer(TextureMapperPlatformLayer*);
    9090    void setAnimations(const TextureMapperAnimations&);
    91     const TextureMapperAnimations& animations() const { return m_animations; }
    9291    void setBackingStore(TextureMapperBackingStore*);
    9392
  • trunk/Source/WebCore/platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.cpp

    r230955 r233080  
    10851085bool CoordinatedGraphicsLayer::shouldHaveBackingStore() const
    10861086{
    1087     return drawsContent() && contentsAreVisible() && !m_size.isEmpty()
    1088         && (!!opacity() || m_animations.hasActiveAnimationsOfType(AnimatedPropertyOpacity));
     1087    return drawsContent() && contentsAreVisible() && !m_size.isEmpty();
    10891088}
    10901089
  • trunk/Source/WebKit/ChangeLog

    r233079 r233080  
     12018-06-22  Michael Catanzaro  <mcatanzaro@igalia.com>
     2
     3        REGRESSION(r230950): [GTK] WebKit::CoordinatedBackingStoreTile::setBackBuffer(): WebKitWebProcess killed by SIGSEGV (ASSERTION FAILED: it != m_tiles.end())
     4        https://bugs.webkit.org/show_bug.cgi?id=186206
     5
     6        Unreviewed manual rollout of r230950
     7
     8        * Shared/CoordinatedGraphics/CoordinatedGraphicsScene.cpp:
     9        (WebKit::layerShouldHaveBackingStore):
     10
    1112018-06-20  Darin Adler  <darin@apple.com>
    212
  • trunk/Source/WebKit/Shared/CoordinatedGraphics/CoordinatedGraphicsScene.cpp

    r230955 r233080  
    3838static bool layerShouldHaveBackingStore(TextureMapperLayer* layer)
    3939{
    40     return layer->drawsContent() && layer->contentsAreVisible() && !layer->size().isEmpty()
    41         && (!!layer->opacity() || layer->animations().hasActiveAnimationsOfType(AnimatedPropertyOpacity));
     40    return layer->drawsContent() && layer->contentsAreVisible() && !layer->size().isEmpty();
    4241}
    4342
Note: See TracChangeset for help on using the changeset viewer.