Changeset 233107 in webkit

Timestamp:

Jun 22, 2018 4:05:50 PM (6 years ago)

Author:

dbates@webkit.org

Message:

Security EWS: bots fails with exception 'NoneType' object has no attribute 'is_closed'
​https://bugs.webkit.org/show_bug.cgi?id=186923

Reviewed by Lucas Forschler.

Attachments downloaded from the status server (​http://webkit-queues.webkit.org) do not
have an associated Bug object (i.e. Attachment.bug() is None) and reflect the state they
were in, including flags set, at the time they were uploaded to the status server. We
will add support for fetching up-to-date status info about the attachment and its bug
in <​https://bugs.webkit.org/show_bug.cgi?id=186817>. For now, we only check if the
bug associated with the patch we are processing is closed if the attachment has a
non-None Bug object.

• Scripts/webkitpy/tool/bot/earlywarningsystemtask.py:

(EarlyWarningSystemTask.validate):

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• Scripts/webkitpy/tool/bot/earlywarningsystemtask.py (modified) (1 diff)

trunk/Tools/ChangeLog

@@ +1 @@
+2018-06-22  Daniel Bates  <dabates@apple.com>
+
+        Security EWS: bots fails with exception 'NoneType' object has no attribute 'is_closed'
+        https://bugs.webkit.org/show_bug.cgi?id=186923
+
+        Reviewed by Lucas Forschler.
+
+        Attachments downloaded from the status server (http://webkit-queues.webkit.org) do not
+        have an associated Bug object (i.e. Attachment.bug() is None) and reflect the state they
+        were in, including flags set, at the time they were uploaded to the status server. We
+        will add support for fetching up-to-date status info about the attachment and its bug
+        in <https://bugs.webkit.org/show_bug.cgi?id=186817>. For now, we only check if the
+        bug associated with the patch we are processing is closed if the attachment has a
+        non-None Bug object.
+
+        * Scripts/webkitpy/tool/bot/earlywarningsystemtask.py:
+        (EarlyWarningSystemTask.validate):
+
 2018-06-22  Ross Kirsling  <ross.kirsling@sony.com>
 

trunk/Tools/Scripts/webkitpy/tool/bot/earlywarningsystemtask.py

@@ -42 +42 @@
 
     def validate(self):
+        # FIXME: Need a way to ask the status server for latest status of a security bug.
+        # Attachments downloaded from the status server do not have an associated bug and
+        # reflect the Bugzilla state at the time they were uploaded to the status server.
+        # See <https://bugs.webkit.org/show_bug.cgi?id=186817>.
         self._patch = self._delegate.refetch_patch(self._patch)
         if self._patch.is_obsolete():
             self.error = "Patch is obsolete."
             return False
-        if self._patch.bug().is_closed():
+        if self._patch.bug() and self._patch.bug().is_closed():
             self.error = "Bug is already closed."
             return False