Changeset 233376 in webkit
- Timestamp:
- Jun 29, 2018 4:33:30 PM (6 years ago)
- Location:
- trunk
- Files:
-
- 2 added
- 4 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/LayoutTests/ChangeLog
r233370 r233376 1 2018-06-29 Nan Wang <n_wang@apple.com> 2 3 AX: [iOS] VoiceOver scroll position is jumpy in frames 4 https://bugs.webkit.org/show_bug.cgi?id=186956 5 6 Reviewed by Simon Fraser. 7 8 * fast/scrolling/ios/iframe-scroll-into-view-expected.html: Added. 9 * fast/scrolling/ios/iframe-scroll-into-view.html: Added. 10 1 11 2018-06-29 Truitt Savell <tsavell@apple.com> 2 12 -
trunk/Source/WebCore/ChangeLog
r233374 r233376 1 2018-06-29 Nan Wang <n_wang@apple.com> 2 3 AX: [iOS] VoiceOver scroll position is jumpy in frames 4 https://bugs.webkit.org/show_bug.cgi?id=186956 5 6 Reviewed by Simon Fraser. 7 8 iOS is using delegate scrolling and we should not take into account 9 the scroll offset when converting rects. 10 11 Also fixed a issue where we want to scroll the element into view even 12 if it's partially visible. 13 14 Test: fast/scrolling/ios/iframe-scroll-into-view.html 15 16 * accessibility/AccessibilityObject.cpp: 17 (WebCore::AccessibilityObject::scrollToMakeVisible const): 18 * platform/ScrollView.cpp: 19 (WebCore::ScrollView::contentsToContainingViewContents const): 20 1 21 2018-06-29 Chris Dumez <cdumez@apple.com> 2 22 -
trunk/Source/WebCore/accessibility/AccessibilityObject.cpp
r233122 r233376 2993 2993 2994 2994 if (auto* renderer = this->renderer()) 2995 renderer->scrollRectToVisible(SelectionRevealMode::Reveal, boundingBoxRect(), false, ScrollAlignment::alignCenterIfN otVisible, ScrollAlignment::alignCenterIfNotVisible, ShouldAllowCrossOriginScrolling::Yes);2995 renderer->scrollRectToVisible(SelectionRevealMode::Reveal, boundingBoxRect(), false, ScrollAlignment::alignCenterIfNeeded, ScrollAlignment::alignCenterIfNeeded, ShouldAllowCrossOriginScrolling::Yes); 2996 2996 } 2997 2997 -
trunk/Source/WebCore/platform/ScrollView.cpp
r233116 r233376 848 848 IntRect ScrollView::contentsToContainingViewContents(IntRect rect) const 849 849 { 850 if (delegatesScrolling()) 851 return convertToContainingView(contentsToView(rect)); 852 850 853 if (const ScrollView* parentScrollView = parent()) { 851 854 IntRect rectInContainingView = convertToContainingView(contentsToView(rect));
Note: See TracChangeset
for help on using the changeset viewer.