Changeset 233462 in webkit

Timestamp:

Jul 3, 2018 8:01:55 AM (6 years ago)

Author:

commit-queue@webkit.org

Message:

REGRESSION (r232186): Hardware-accelerated CSS animations using steps() timing function no longer work
​https://bugs.webkit.org/show_bug.cgi?id=186129

Patch by Frederic Wang <​fwang@igalia.com> on 2018-07-03
Reviewed by Antoine Quint.

Source/WebCore:

When the WebAnimationsCSSIntegration flag is enabled, animating the transform property with
a steps() timing function no longer works. This is because the WebAnimation code wrongly
assumes that the transform property can always be accelerated (for counterexamples, see
GraphicsLayerCA::animationCanBeAccelerated). For consistency with AnimationBase, we make
WebAnimation fallback to non-accelerated mode when RenderBoxModelObject::startAnimation
fails. This addresses the regression previously mentioned.

Test: http/wpt/css/css-animations/start-animation-001.html

• animation/KeyframeEffectReadOnly.cpp:

(WebCore::KeyframeEffectReadOnly::applyPendingAcceleratedActions): Fallback to
non-accelerated mode if startAnimation failed.

LayoutTests:

Add a test to ensure that accelerated and non-accelerated animations are properly started
when WebAnimationsCSSIntegration is enabled. In particular, consider the case of animated
transform using steps() timing function.

• http/wpt/css/css-animations/start-animation-001-expected.html: Added.
• http/wpt/css/css-animations/start-animation-001.html: Added.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/http/wpt/css/css-animations/start-animation-001-expected.html (added)
• LayoutTests/http/wpt/css/css-animations/start-animation-001.html (added)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/animation/KeyframeEffectReadOnly.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2018-07-03  Frederic Wang  <fwang@igalia.com>
+
+        REGRESSION (r232186): Hardware-accelerated CSS animations using steps() timing function no longer work
+        https://bugs.webkit.org/show_bug.cgi?id=186129
+
+        Reviewed by Antoine Quint.
+
+        Add a test to ensure that accelerated and non-accelerated animations are properly started
+        when WebAnimationsCSSIntegration is enabled. In particular, consider the case of animated
+        transform using steps() timing function.
+
+        * http/wpt/css/css-animations/start-animation-001-expected.html: Added.
+        * http/wpt/css/css-animations/start-animation-001.html: Added.
+
 2018-07-03  Frederic Wang  <fred.wang@free.fr>
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2018-07-03  Frederic Wang  <fwang@igalia.com>
+
+        REGRESSION (r232186): Hardware-accelerated CSS animations using steps() timing function no longer work
+        https://bugs.webkit.org/show_bug.cgi?id=186129
+
+        Reviewed by Antoine Quint.
+
+        When the WebAnimationsCSSIntegration flag is enabled, animating the transform property with
+        a steps() timing function no longer works. This is because the WebAnimation code wrongly
+        assumes that the transform property can always be accelerated (for counterexamples, see
+        GraphicsLayerCA::animationCanBeAccelerated). For consistency with AnimationBase, we make
+        WebAnimation fallback to non-accelerated mode when RenderBoxModelObject::startAnimation
+        fails. This addresses the regression previously mentioned.
+
+        Test: http/wpt/css/css-animations/start-animation-001.html
+
+        * animation/KeyframeEffectReadOnly.cpp:
+        (WebCore::KeyframeEffectReadOnly::applyPendingAcceleratedActions): Fallback to
+        non-accelerated mode if startAnimation failed.
+
 2018-07-03  David Kilzer  <ddkilzer@apple.com>
 

trunk/Source/WebCore/animation/KeyframeEffectReadOnly.cpp

@@ -1255 +1255 @@
         switch (action) {
         case AcceleratedAction::Play:
-            compositedRenderer->startAnimation(timeOffset, backingAnimationForCompositedRenderer().ptr(), m_blendingKeyframes);
+            if (!compositedRenderer->startAnimation(timeOffset, backingAnimationForCompositedRenderer().ptr(), m_blendingKeyframes)) {
+                m_shouldRunAccelerated = false;
+                m_lastRecordedAcceleratedAction = AcceleratedAction::Stop;
+                return;
+            }
             break;
         case AcceleratedAction::Pause: