Changeset 233548 in webkit

Timestamp:

Jul 5, 2018 4:17:40 PM (6 years ago)

Author:

BJ Burg

Message:

REGRESSION: ASSERT under WebAutomationSessionProxy::computeElementLayout when elementInViewClientCenterPoint returns nullopt
​https://bugs.webkit.org/show_bug.cgi?id=187367
<rdar://problem/41861346>

Reviewed by Timothy Hatcher.

• WebProcess/Automation/WebAutomationSessionProxy.cpp:

(WebKit::WebAutomationSessionProxy::computeElementLayout):
There's no reason to unwrap this optional, as the IPC argument type is std::optional<IntPoint>.

Location:

trunk/Source/WebKit

Files:

• ChangeLog (modified) (1 diff)
• WebProcess/Automation/WebAutomationSessionProxy.cpp (modified) (1 diff)

trunk/Source/WebKit/ChangeLog

@@ +1 @@
+2018-07-05  Brian Burg  <bburg@apple.com>
+
+        REGRESSION: ASSERT under WebAutomationSessionProxy::computeElementLayout when elementInViewClientCenterPoint returns nullopt
+        https://bugs.webkit.org/show_bug.cgi?id=187367
+        <rdar://problem/41861346>
+
+        Reviewed by Timothy Hatcher.
+
+        * WebProcess/Automation/WebAutomationSessionProxy.cpp:
+        (WebKit::WebAutomationSessionProxy::computeElementLayout):
+        There's no reason to unwrap this optional, as the IPC argument type is std::optional<IntPoint>.
+
 2018-07-05  Tim Horton  <timothy_horton@apple.com>
 

trunk/Source/WebKit/WebProcess/Automation/WebAutomationSessionProxy.cpp

@@ -618 +618 @@
     }
 
-    WebProcess::singleton().parentProcessConnection()->send(Messages::WebAutomationSession::DidComputeElementLayout(callbackID, resultElementBounds, resultInViewCenterPoint.value(), isObscured, String()), 0);
+    WebProcess::singleton().parentProcessConnection()->send(Messages::WebAutomationSession::DidComputeElementLayout(callbackID, resultElementBounds, resultInViewCenterPoint, isObscured, String()), 0);
 }