Changeset 233857 in webkit

Timestamp:

Jul 16, 2018 11:55:08 AM (6 years ago)

Author:

Chris Dumez

Message:

Make sure LibWebRTCMediaEndpoint is always destroyed on the main thread
​https://bugs.webkit.org/show_bug.cgi?id=187702

Reviewed by Youenn Fablet.

Make sure LibWebRTCMediaEndpoint is always constructed and destructed on the main thread since
it has a Timer data member and it would not be safe otherwise. LibWebRTCMediaEndpoint is
ThreadSafeRefCounted and frequently passed to other threads.

• Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.cpp:

(WebCore::LibWebRTCMediaEndpoint::LibWebRTCMediaEndpoint):

• Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.h:

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.cpp (modified) (1 diff)
• Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.h (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2018-07-16  Chris Dumez  <cdumez@apple.com>
+
+        Make sure LibWebRTCMediaEndpoint is always destroyed on the main thread
+        https://bugs.webkit.org/show_bug.cgi?id=187702
+
+        Reviewed by Youenn Fablet.
+
+        Make sure LibWebRTCMediaEndpoint is always constructed and destructed on the main thread since
+        it has a Timer data member and it would not be safe otherwise. LibWebRTCMediaEndpoint is
+        ThreadSafeRefCounted and frequently passed to other threads.
+
+        * Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.cpp:
+        (WebCore::LibWebRTCMediaEndpoint::LibWebRTCMediaEndpoint):
+        * Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.h:
+
 2018-07-16  Sihui Liu  <sihui_liu@apple.com>
 

trunk/Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.cpp

@@ -75 +75 @@
 #endif
 {
+    ASSERT(isMainThread());
     ASSERT(client.factory());
 }

trunk/Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.h

@@ -58 +58 @@
 
 class LibWebRTCMediaEndpoint
-    : public ThreadSafeRefCounted<LibWebRTCMediaEndpoint>
+    : public ThreadSafeRefCounted<LibWebRTCMediaEndpoint, WTF::DestructionThread::Main>
     , private webrtc::PeerConnectionObserver
     , private webrtc::RTCStatsCollectorCallback