Changeset 233878 in webkit


Ignore:
Timestamp:
Jul 16, 2018 7:17:38 PM (6 years ago)
Author:
commit-queue@webkit.org
Message:

Fix API Test failures introduced by r233865
https://bugs.webkit.org/show_bug.cgi?id=187720

Unreviewed APITest fix after r233865.

Fullscreen can now only be initiated from a window that is on screen.

Patch by Jeremy Jones <jeremyj@apple.com> on 2018-07-16

  • TestWebKitAPI/Tests/WebKitCocoa/FullscreenDelegate.mm:

(TestWebKitAPI::TEST):

  • TestWebKitAPI/Tests/WebKitCocoa/FullscreenTopContentInset.mm:

(TestWebKitAPI::TEST):

Location:
trunk/Tools
Files:
3 edited

Legend:

Unmodified
Added
Removed
  • trunk/Tools/ChangeLog

    r233869 r233878  
     12018-07-16  Jeremy Jones  <jeremyj@apple.com>
     2
     3        Fix API Test failures introduced by r233865
     4        https://bugs.webkit.org/show_bug.cgi?id=187720
     5
     6        Unreviewed APITest fix after r233865.
     7
     8        Fullscreen can now only be initiated from a window that is on screen.
     9
     10        * TestWebKitAPI/Tests/WebKitCocoa/FullscreenDelegate.mm:
     11        (TestWebKitAPI::TEST):
     12        * TestWebKitAPI/Tests/WebKitCocoa/FullscreenTopContentInset.mm:
     13        (TestWebKitAPI::TEST):
     14
    1152018-07-11  Dean Jackson  <dino@apple.com>
    216
  • trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/FullscreenDelegate.mm

    r211891 r233878  
    9595    RetainPtr<NSWindow> window = adoptNS([[NSWindow alloc] initWithContentRect:[webView frame] styleMask:NSWindowStyleMaskBorderless backing:NSBackingStoreBuffered defer:NO]);
    9696    [[window contentView] addSubview:webView.get()];
     97    [window makeKeyAndOrderFront:nil];
    9798
    9899    NSURLRequest *request = [NSURLRequest requestWithURL:[[NSBundle mainBundle] URLForResource:@"FullscreenDelegate" withExtension:@"html" subdirectory:@"TestWebKitAPI.resources"]];
  • trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/FullscreenTopContentInset.mm

    r209782 r233878  
    6666    RetainPtr<NSWindow> window = adoptNS([[NSWindow alloc] initWithContentRect:[webView frame] styleMask:NSWindowStyleMaskBorderless backing:NSBackingStoreBuffered defer:NO]);
    6767    [[window contentView] addSubview:webView.get()];
     68    [window makeKeyAndOrderFront:nil];
    6869
    6970    NSURLRequest *request = [NSURLRequest requestWithURL:[[NSBundle mainBundle] URLForResource:@"FullscreenTopContentInset" withExtension:@"html" subdirectory:@"TestWebKitAPI.resources"]];
Note: See TracChangeset for help on using the changeset viewer.