Changeset 233889 in webkit


Ignore:
Timestamp:
Jul 17, 2018 11:04:46 AM (6 years ago)
Author:
commit-queue@webkit.org
Message:

[macOS] TestWebKitAPI.PictureInPicture.WKUIDelegate is timing out
https://bugs.webkit.org/show_bug.cgi?id=187730

Patch by Aditya Keerthi <Aditya Keerthi> on 2018-07-17
Reviewed by Jer Noble.

This regression was introduced by r233865. PIP can now only be initiated from a
window that is on screen.

  • TestWebKitAPI/Tests/WebKitCocoa/PictureInPictureDelegate.mm:

(TestWebKitAPI::TEST):

Location:
trunk/Tools
Files:
2 edited

Legend:

Unmodified
Added
Removed
  • trunk/Tools/ChangeLog

    r233888 r233889  
     12018-07-17  Aditya Keerthi  <akeerthi@apple.com>
     2
     3        [macOS] TestWebKitAPI.PictureInPicture.WKUIDelegate is timing out
     4        https://bugs.webkit.org/show_bug.cgi?id=187730
     5
     6        Reviewed by Jer Noble.
     7
     8        This regression was introduced by r233865. PIP can now only be initiated from a
     9        window that is on screen.
     10
     11        * TestWebKitAPI/Tests/WebKitCocoa/PictureInPictureDelegate.mm:
     12        (TestWebKitAPI::TEST):
     13
    1142018-07-17  John Wilander  <wilander@apple.com>
    215
  • trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/PictureInPictureDelegate.mm

    r229257 r233889  
    123123    RetainPtr<NSWindow> window = adoptNS([[NSWindow alloc] initWithContentRect:[webView frame] styleMask:NSWindowStyleMaskBorderless backing:NSBackingStoreBuffered defer:NO]);
    124124    [[window contentView] addSubview:webView.get()];
     125    [window makeKeyAndOrderFront:nil];
    125126
    126127    NSURLRequest *request = [NSURLRequest requestWithURL:[[NSBundle mainBundle] URLForResource:@"PictureInPictureDelegate" withExtension:@"html" subdirectory:@"TestWebKitAPI.resources"]];
Note: See TracChangeset for help on using the changeset viewer.