Changeset 233921 in webkit

Timestamp:

Jul 18, 2018 11:40:20 AM (6 years ago)

Author:

aakash_jain@apple.com

Message:

[ews-build] Add build step to run layout-test
​https://bugs.webkit.org/show_bug.cgi?id=187674

Reviewed by Lucas Forschler.

• BuildSlaveSupport/ews-build/steps.py:

(RunWebKitTests): Added build step to run layout-tests. This is similar to current EWS.

• BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
• BuildSlaveSupport/ews-build/factories.py: Added build-step to run layout-test in iOSSimulatorFactory.

Location:

trunk/Tools

Files:

• BuildSlaveSupport/ews-build/factories.py (modified) (1 diff)
• BuildSlaveSupport/ews-build/steps.py (modified) (1 diff)
• BuildSlaveSupport/ews-build/steps_unittest.py (modified) (1 diff)
• ChangeLog (modified) (1 diff)

trunk/Tools/BuildSlaveSupport/ews-build/factories.py

@@ -89 +89 @@
 
 class iOSSimulatorFactory(BuildFactory):
-    pass
+    def __init__(self, platform, configuration=None, architectures=None, additionalArguments=None, **kwargs):
+        BuildFactory.__init__(self, platform, configuration, architectures, additionalArguments)
+        self.addStep(RunWebKitTests())
 
 

trunk/Tools/BuildSlaveSupport/ews-build/steps.py

@@ -259 +259 @@
     def __init__(self, **kwargs):
         super(KillOldProcesses, self).__init__(timeout=60, **kwargs)
+
+
+class RunWebKitTests(shell.Test):
+    name = 'layout-tests'
+    description = ['layout-tests running']
+    descriptionDone = ['layout-tests']
+    resultDirectory = 'layout-test-results'
+    command = ['python', 'Tools/Scripts/run-webkit-tests',
+               '--no-build',
+               '--no-new-test-results',
+               '--no-show-results',
+               '--exit-after-n-failures', '30',
+               '--skip-failing-tests',
+               WithProperties('--%(configuration)s')]
+
+    def start(self):
+        platform = self.getProperty('platform')
+        appendCustomBuildFlags(self, platform, self.getProperty('fullPlatform'))
+        additionalArguments = self.getProperty('additionalArguments')
+
+        self.setCommand(self.command + ['--results-directory', self.resultDirectory])
+        self.setCommand(self.command + ['--debug-rwt-logging'])
+
+        if additionalArguments:
+            self.setCommand(self.command + additionalArguments)
+        return shell.Test.start(self)

trunk/Tools/BuildSlaveSupport/ews-build/steps_unittest.py

@@ -710 +710 @@
 
 
+class TestRunWebKitTests(BuildStepMixinAdditions, unittest.TestCase):
+    def setUp(self):
+        self.longMessage = True
+        return self.setUpBuildStep()
+
+    def tearDown(self):
+        return self.tearDownBuildStep()
+
+    def test_success(self):
+        self.setupStep(RunWebKitTests())
+        self.setProperty('fullPlatform', 'ios-simulator')
+        self.setProperty('configuration', 'release')
+        self.expectRemoteCommands(
+            ExpectShell(workdir='wkdir',
+                        command=['python', 'Tools/Scripts/run-webkit-tests', '--no-build', '--no-new-test-results', '--no-show-results', '--exit-after-n-failures', '30', '--skip-failing-tests', '--release', '--results-directory', 'layout-test-results', '--debug-rwt-logging'],
+                        )
+            + 0,
+        )
+        self.expectOutcome(result=SUCCESS, state_string='layout-tests')
+        return self.runStep()
+
+    def test_failure(self):
+        self.setupStep(RunWebKitTests())
+        self.setProperty('fullPlatform', 'ios-simulator')
+        self.setProperty('configuration', 'release')
+        self.expectRemoteCommands(
+            ExpectShell(workdir='wkdir',
+                        command=['python', 'Tools/Scripts/run-webkit-tests', '--no-build', '--no-new-test-results', '--no-show-results', '--exit-after-n-failures', '30', '--skip-failing-tests', '--release', '--results-directory', 'layout-test-results', '--debug-rwt-logging'],
+                        )
+            + ExpectShell.log('stdio', stdout='9 failures found.')
+            + 2,
+        )
+        self.expectOutcome(result=FAILURE, state_string='layout-tests (failure)')
+        return self.runStep()
+
+
 if __name__ == '__main__':
     unittest.main()

trunk/Tools/ChangeLog

@@ +1 @@
+2018-07-18  Aakash Jain  <aakash_jain@apple.com>
+
+        [ews-build] Add build step to run layout-test
+        https://bugs.webkit.org/show_bug.cgi?id=187674
+
+        Reviewed by Lucas Forschler.
+
+        * BuildSlaveSupport/ews-build/steps.py:
+        (RunWebKitTests): Added build step to run layout-tests. This is similar to current EWS.
+        * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
+        * BuildSlaveSupport/ews-build/factories.py: Added build-step to run layout-test in iOSSimulatorFactory.
+
 2018-07-18  Wenson Hsieh  <wenson_hsieh@apple.com>