Changeset 234010 in webkit

Timestamp:

Jul 19, 2018 4:11:24 PM (6 years ago)

Author:

stephan.szabo@sony.com

Message:

[WinCairo] Support DEVELOPER_MODE for allowing inspection of web inspector
​https://bugs.webkit.org/show_bug.cgi?id=187786

Reviewed by Fujii Hironori.

.:

• Source/cmake/OptionsWinCairo.cmake: Add ENABLE_DEVELOPER_MODE

to build when DEVELOPER_MODE is turned on at cmake time.

Tools:

• Scripts/webkitdirs.pm:

(generateBuildSystemFromCMakeProject): Turn on DEVELOPER_MODE
for WinCairo builds.

Location:

trunk

Files:

• ChangeLog (modified) (1 diff)
• Source/cmake/OptionsWinCairo.cmake (modified) (1 diff)
• Tools/ChangeLog (modified) (1 diff)
• Tools/Scripts/webkitdirs.pm (modified) (1 diff)

trunk/ChangeLog

@@ +1 @@
+2018-07-19  Stephan Szabo  <stephan.szabo@sony.com>
+
+        [WinCairo] Support DEVELOPER_MODE for allowing inspection of web inspector
+        https://bugs.webkit.org/show_bug.cgi?id=187786
+
+        Reviewed by Fujii Hironori.
+
+        * Source/cmake/OptionsWinCairo.cmake: Add ENABLE_DEVELOPER_MODE
+        to build when DEVELOPER_MODE is turned on at cmake time.
+
 2018-07-18  Michael Catanzaro  <mcatanzaro@igalia.com>
 

trunk/Source/cmake/OptionsWinCairo.cmake

@@ -34 +34 @@
 set(COREFOUNDATION_LIBRARY CFlite)
 
+SET_AND_EXPOSE_TO_BUILD(ENABLE_DEVELOPER_MODE ${DEVELOPER_MODE})
+
 add_definitions(-DWTF_PLATFORM_WIN_CAIRO=1)

trunk/Tools/ChangeLog

@@ +1 @@
+2018-07-19  Stephan Szabo  <stephan.szabo@sony.com>
+
+        [WinCairo] Support DEVELOPER_MODE for allowing inspection of web inspector
+        https://bugs.webkit.org/show_bug.cgi?id=187786
+
+        Reviewed by Fujii Hironori.
+
+        * Scripts/webkitdirs.pm:
+        (generateBuildSystemFromCMakeProject): Turn on DEVELOPER_MODE
+        for WinCairo builds.
+
 2018-07-19  Dean Jackson  <dino@apple.com>
 

trunk/Tools/Scripts/webkitdirs.pm

@@ -2270 +2270 @@
 
     # Some ports have production mode, but build-webkit should always use developer mode.
-    push @args, "-DDEVELOPER_MODE=ON" if isGtk() || isJSCOnly() || isWPE();
+    push @args, "-DDEVELOPER_MODE=ON" if isGtk() || isJSCOnly() || isWPE() || isWinCairo();
 
     push @args, @cmakeArgs if @cmakeArgs;