Changeset 234023 in webkit

Timestamp:

Jul 19, 2018 9:53:59 PM (6 years ago)

Author:

Chris Dumez

Message:

Null pointer dereference under WebPage::autofillLoginCredentials()
​https://bugs.webkit.org/show_bug.cgi?id=187823
<rdar://problem/37152195>

Reviewed by David Kilzer.

Deal with m_assistedNode being null under WebPage::autofillLoginCredentials().

• WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::WebPage::autofillLoginCredentials):

Location:

trunk/Source/WebKit

Files:

• ChangeLog (modified) (1 diff)
• WebProcess/WebPage/ios/WebPageIOS.mm (modified) (1 diff)

trunk/Source/WebKit/ChangeLog

@@ +1 @@
+2018-07-19  Chris Dumez  <cdumez@apple.com>
+
+        Null pointer dereference under WebPage::autofillLoginCredentials()
+        https://bugs.webkit.org/show_bug.cgi?id=187823
+        <rdar://problem/37152195>
+
+        Reviewed by David Kilzer.
+
+        Deal with m_assistedNode being null under WebPage::autofillLoginCredentials().
+
+        * WebProcess/WebPage/ios/WebPageIOS.mm:
+        (WebKit::WebPage::autofillLoginCredentials):
+
 2018-07-19  Chris Dumez  <cdumez@apple.com>
 

trunk/Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm

@@ -2466 +2466 @@
 void WebPage::autofillLoginCredentials(const String& username, const String& password)
 {
-    if (is<HTMLInputElement>(*m_assistedNode)) {
+    if (is<HTMLInputElement>(m_assistedNode.get())) {
         if (auto autofillElements = AutofillElements::computeAutofillElements(downcast<HTMLInputElement>(*m_assistedNode)))
             autofillElements->autofill(username, password);