Changeset 234053 in webkit

Timestamp:

Jul 20, 2018 10:36:57 AM (6 years ago)

Author:

Alan Bujtas

Message:

Update FrameView::paintContents to use release logging.
​https://bugs.webkit.org/show_bug.cgi?id=187854
<rdar://problem/42432371>

Reviewed by Simon Fraser.

Adding release logging helps identifying blank content cases.

• page/FrameView.cpp:

(WebCore::FrameView::paintContents):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• page/FrameView.cpp (modified) (2 diffs)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2018-07-20  Zalan Bujtas  <zalan@apple.com>
+
+        Update FrameView::paintContents to use release logging.
+        https://bugs.webkit.org/show_bug.cgi?id=187854
+        <rdar://problem/42432371>
+
+        Reviewed by Simon Fraser.
+
+        Adding release logging helps identifying blank content cases. 
+
+        * page/FrameView.cpp:
+        (WebCore::FrameView::paintContents):
+
 2018-07-20  Jer Noble  <jer.noble@apple.com>
 

trunk/Source/WebCore/page/FrameView.cpp

@@ -119 +119 @@
 #endif
 
+#define RELEASE_LOG_IF_ALLOWED(fmt, ...) RELEASE_LOG_IF(frame().page() && frame().page()->isAlwaysOnLoggingAllowed(), Layout, "%p - FrameView::" fmt, this, ##__VA_ARGS__)
+
 namespace WebCore {
 
@@ -4141 +4143 @@
 
     ASSERT(!needsLayout());
-    if (needsLayout())
-        return;
+    if (needsLayout()) {
+        RELEASE_LOG_IF_ALLOWED("FrameView::paintContents() - not painting because render tree needs layout (is main frame %d)", frame().isMainFrame());
+        return;
+    }
 
     PaintingState paintingState;