Changeset 234580 in webkit

Timestamp:

Aug 4, 2018 1:07:13 PM (6 years ago)

Author:

ddkilzer@apple.com

Message:

REGRESSION (r208953): TemplateObjectDescriptor constructor calculates m_hash on use-after-move variable
<​https://webkit.org/b/188331>

Reviewed by Yusuke Suzuki.

• runtime/TemplateObjectDescriptor.h:

(JSC::TemplateObjectDescriptor::TemplateObjectDescriptor):
Use m_rawstrings instead of rawStrings to calculate hash.

Location:

trunk/Source/JavaScriptCore

Files:

• ChangeLog (modified) (1 diff)
• runtime/TemplateObjectDescriptor.h (modified) (1 diff)

trunk/Source/JavaScriptCore/ChangeLog

@@ +1 @@
+2018-08-04  David Kilzer  <ddkilzer@apple.com>
+
+        REGRESSION (r208953): TemplateObjectDescriptor constructor calculates m_hash on use-after-move variable
+        <https://webkit.org/b/188331>
+
+        Reviewed by Yusuke Suzuki.
+
+        * runtime/TemplateObjectDescriptor.h:
+        (JSC::TemplateObjectDescriptor::TemplateObjectDescriptor):
+        Use `m_rawstrings` instead of `rawStrings` to calculate hash.
+
 2018-08-03  Saam Barati  <sbarati@apple.com>
 

trunk/Source/JavaScriptCore/runtime/TemplateObjectDescriptor.h

@@ -82 +82 @@
     : m_rawStrings(WTFMove(rawStrings))
     , m_cookedStrings(WTFMove(cookedStrings))
-    , m_hash(calculateHash(rawStrings))
+    , m_hash(calculateHash(m_rawStrings))
 {
 }