Changeset 234723 in webkit


Ignore:
Timestamp:
Aug 9, 2018 6:36:51 AM (6 years ago)
Author:
ajuma@chromium.org
Message:

Import WPTs for IntersectionObserver
​https://bugs.webkit.org/show_bug.cgi?id=188416

Reviewed by Simon Fraser.

LayoutTests/imported/w3c:

  • resources/import-expectations.json:
  • web-platform-tests/intersection-observer/META.yml: Added.
  • web-platform-tests/intersection-observer/bounding-box-expected.txt: Added.
  • web-platform-tests/intersection-observer/bounding-box.html: Added.
  • web-platform-tests/intersection-observer/client-rect-expected.txt: Added.
  • web-platform-tests/intersection-observer/client-rect.html: Added.
  • web-platform-tests/intersection-observer/containing-block-expected.txt: Added.
  • web-platform-tests/intersection-observer/containing-block.html: Added.
  • web-platform-tests/intersection-observer/cross-origin-iframe-expected.txt: Added.
  • web-platform-tests/intersection-observer/cross-origin-iframe.html: Added.
  • web-platform-tests/intersection-observer/disconnect-expected.txt: Added.
  • web-platform-tests/intersection-observer/disconnect.html: Added.
  • web-platform-tests/intersection-observer/display-none-expected.txt: Added.
  • web-platform-tests/intersection-observer/display-none.html: Added.
  • web-platform-tests/intersection-observer/edge-inclusive-intersection-expected.txt: Added.
  • web-platform-tests/intersection-observer/edge-inclusive-intersection.html: Added.
  • web-platform-tests/intersection-observer/idlharness.window-expected.txt: Added.
  • web-platform-tests/intersection-observer/idlharness.window.html: Added.
  • web-platform-tests/intersection-observer/idlharness.window.js: Added.

(idl_array.self.observer.new.IntersectionObserver):

  • web-platform-tests/intersection-observer/iframe-no-root-expected.txt: Added.
  • web-platform-tests/intersection-observer/iframe-no-root.html: Added.
  • web-platform-tests/intersection-observer/inline-client-rect-expected.txt: Added.
  • web-platform-tests/intersection-observer/inline-client-rect.html: Added.
  • web-platform-tests/intersection-observer/isIntersecting-change-events-expected.txt: Added.
  • web-platform-tests/intersection-observer/isIntersecting-change-events.html: Added.
  • web-platform-tests/intersection-observer/multiple-targets-expected.txt: Added.
  • web-platform-tests/intersection-observer/multiple-targets.html: Added.
  • web-platform-tests/intersection-observer/multiple-thresholds-expected.txt: Added.
  • web-platform-tests/intersection-observer/multiple-thresholds.html: Added.
  • web-platform-tests/intersection-observer/observer-attributes-expected.txt: Added.
  • web-platform-tests/intersection-observer/observer-attributes.html: Added.
  • web-platform-tests/intersection-observer/observer-exceptions-expected.txt: Added.
  • web-platform-tests/intersection-observer/observer-exceptions.html: Added.
  • web-platform-tests/intersection-observer/observer-in-iframe.html: Added.
  • web-platform-tests/intersection-observer/observer-without-js-reference-expected.txt: Added.
  • web-platform-tests/intersection-observer/observer-without-js-reference.html: Added.
  • web-platform-tests/intersection-observer/remove-element-expected.txt: Added.
  • web-platform-tests/intersection-observer/remove-element.html: Added.
  • web-platform-tests/intersection-observer/resources/cross-origin-subframe.html: Added.
  • web-platform-tests/intersection-observer/resources/iframe-no-root-subframe.html: Added.
  • web-platform-tests/intersection-observer/resources/intersection-observer-test-utils.js: Added.

(waitForNotification):
(runTestCycle):
(contentBounds):
(borderBoxBounds):
(clientBounds):
(rectArea):
(checkRect):
(checkLastEntry):
(checkJsonEntry):
(checkJsonEntries):

  • web-platform-tests/intersection-observer/resources/observer-in-iframe-subframe.html: Added.
  • web-platform-tests/intersection-observer/resources/timestamp-subframe.html: Added.
  • web-platform-tests/intersection-observer/resources/w3c-import.log: Added.
  • web-platform-tests/intersection-observer/root-margin-expected.txt: Added.
  • web-platform-tests/intersection-observer/root-margin.html: Added.
  • web-platform-tests/intersection-observer/same-document-no-root-expected.txt: Added.
  • web-platform-tests/intersection-observer/same-document-no-root.html: Added.
  • web-platform-tests/intersection-observer/same-document-root-expected.txt: Added.
  • web-platform-tests/intersection-observer/same-document-root.html: Added.
  • web-platform-tests/intersection-observer/same-document-zero-size-target-expected.txt: Added.
  • web-platform-tests/intersection-observer/same-document-zero-size-target.html: Added.
  • web-platform-tests/intersection-observer/shadow-content-expected.txt: Added.
  • web-platform-tests/intersection-observer/shadow-content.html: Added.
  • web-platform-tests/intersection-observer/text-target-expected.txt: Added.
  • web-platform-tests/intersection-observer/text-target.html: Added.
  • web-platform-tests/intersection-observer/timestamp-expected.txt: Added.
  • web-platform-tests/intersection-observer/timestamp.html: Added.
  • web-platform-tests/intersection-observer/unclipped-root-expected.txt: Added.
  • web-platform-tests/intersection-observer/unclipped-root.html: Added.
  • web-platform-tests/intersection-observer/w3c-import.log: Added.
  • web-platform-tests/intersection-observer/zero-area-element-hidden-expected.txt: Added.
  • web-platform-tests/intersection-observer/zero-area-element-hidden.html: Added.
  • web-platform-tests/intersection-observer/zero-area-element-visible-expected.txt: Added.
  • web-platform-tests/intersection-observer/zero-area-element-visible.html: Added.

Source/WebKit:

Make IntersectionObserver an experimental feature, so that it is enabled in
WebKitTestRunner.

  • Shared/WebPreferences.yaml:

Source/WebKitLegacy/mac:

  • WebView/WebPreferencesPrivate.h:

Tools:

Enable IntersectionObserver in DumpRenderTree.

  • DumpRenderTree/mac/DumpRenderTree.mm:

(enableExperimentalFeatures):
(setWebPreferencesForTestOptions):

  • WebKitTestRunner/TestController.cpp:

(WTR::TestController::resetPreferencesToConsistentValues):

Location:
trunk
Files:
66 added
9 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/imported/w3c/ChangeLog

    r234689 r234723  
     12018-08-09  Ali Juma  <ajuma@chromium.org>
     2
     3        Import WPTs for IntersectionObserver
     4        https://bugs.webkit.org/show_bug.cgi?id=188416
     5
     6        Reviewed by Simon Fraser.
     7
     8        * resources/import-expectations.json:
     9        * web-platform-tests/intersection-observer/META.yml: Added.
     10        * web-platform-tests/intersection-observer/bounding-box-expected.txt: Added.
     11        * web-platform-tests/intersection-observer/bounding-box.html: Added.
     12        * web-platform-tests/intersection-observer/client-rect-expected.txt: Added.
     13        * web-platform-tests/intersection-observer/client-rect.html: Added.
     14        * web-platform-tests/intersection-observer/containing-block-expected.txt: Added.
     15        * web-platform-tests/intersection-observer/containing-block.html: Added.
     16        * web-platform-tests/intersection-observer/cross-origin-iframe-expected.txt: Added.
     17        * web-platform-tests/intersection-observer/cross-origin-iframe.html: Added.
     18        * web-platform-tests/intersection-observer/disconnect-expected.txt: Added.
     19        * web-platform-tests/intersection-observer/disconnect.html: Added.
     20        * web-platform-tests/intersection-observer/display-none-expected.txt: Added.
     21        * web-platform-tests/intersection-observer/display-none.html: Added.
     22        * web-platform-tests/intersection-observer/edge-inclusive-intersection-expected.txt: Added.
     23        * web-platform-tests/intersection-observer/edge-inclusive-intersection.html: Added.
     24        * web-platform-tests/intersection-observer/idlharness.window-expected.txt: Added.
     25        * web-platform-tests/intersection-observer/idlharness.window.html: Added.
     26        * web-platform-tests/intersection-observer/idlharness.window.js: Added.
     27        (idl_array.self.observer.new.IntersectionObserver):
     28        * web-platform-tests/intersection-observer/iframe-no-root-expected.txt: Added.
     29        * web-platform-tests/intersection-observer/iframe-no-root.html: Added.
     30        * web-platform-tests/intersection-observer/inline-client-rect-expected.txt: Added.
     31        * web-platform-tests/intersection-observer/inline-client-rect.html: Added.
     32        * web-platform-tests/intersection-observer/isIntersecting-change-events-expected.txt: Added.
     33        * web-platform-tests/intersection-observer/isIntersecting-change-events.html: Added.
     34        * web-platform-tests/intersection-observer/multiple-targets-expected.txt: Added.
     35        * web-platform-tests/intersection-observer/multiple-targets.html: Added.
     36        * web-platform-tests/intersection-observer/multiple-thresholds-expected.txt: Added.
     37        * web-platform-tests/intersection-observer/multiple-thresholds.html: Added.
     38        * web-platform-tests/intersection-observer/observer-attributes-expected.txt: Added.
     39        * web-platform-tests/intersection-observer/observer-attributes.html: Added.
     40        * web-platform-tests/intersection-observer/observer-exceptions-expected.txt: Added.
     41        * web-platform-tests/intersection-observer/observer-exceptions.html: Added.
     42        * web-platform-tests/intersection-observer/observer-in-iframe.html: Added.
     43        * web-platform-tests/intersection-observer/observer-without-js-reference-expected.txt: Added.
     44        * web-platform-tests/intersection-observer/observer-without-js-reference.html: Added.
     45        * web-platform-tests/intersection-observer/remove-element-expected.txt: Added.
     46        * web-platform-tests/intersection-observer/remove-element.html: Added.
     47        * web-platform-tests/intersection-observer/resources/cross-origin-subframe.html: Added.
     48        * web-platform-tests/intersection-observer/resources/iframe-no-root-subframe.html: Added.
     49        * web-platform-tests/intersection-observer/resources/intersection-observer-test-utils.js: Added.
     50        (waitForNotification):
     51        (runTestCycle):
     52        (contentBounds):
     53        (borderBoxBounds):
     54        (clientBounds):
     55        (rectArea):
     56        (checkRect):
     57        (checkLastEntry):
     58        (checkJsonEntry):
     59        (checkJsonEntries):
     60        * web-platform-tests/intersection-observer/resources/observer-in-iframe-subframe.html: Added.
     61        * web-platform-tests/intersection-observer/resources/timestamp-subframe.html: Added.
     62        * web-platform-tests/intersection-observer/resources/w3c-import.log: Added.
     63        * web-platform-tests/intersection-observer/root-margin-expected.txt: Added.
     64        * web-platform-tests/intersection-observer/root-margin.html: Added.
     65        * web-platform-tests/intersection-observer/same-document-no-root-expected.txt: Added.
     66        * web-platform-tests/intersection-observer/same-document-no-root.html: Added.
     67        * web-platform-tests/intersection-observer/same-document-root-expected.txt: Added.
     68        * web-platform-tests/intersection-observer/same-document-root.html: Added.
     69        * web-platform-tests/intersection-observer/same-document-zero-size-target-expected.txt: Added.
     70        * web-platform-tests/intersection-observer/same-document-zero-size-target.html: Added.
     71        * web-platform-tests/intersection-observer/shadow-content-expected.txt: Added.
     72        * web-platform-tests/intersection-observer/shadow-content.html: Added.
     73        * web-platform-tests/intersection-observer/text-target-expected.txt: Added.
     74        * web-platform-tests/intersection-observer/text-target.html: Added.
     75        * web-platform-tests/intersection-observer/timestamp-expected.txt: Added.
     76        * web-platform-tests/intersection-observer/timestamp.html: Added.
     77        * web-platform-tests/intersection-observer/unclipped-root-expected.txt: Added.
     78        * web-platform-tests/intersection-observer/unclipped-root.html: Added.
     79        * web-platform-tests/intersection-observer/w3c-import.log: Added.
     80        * web-platform-tests/intersection-observer/zero-area-element-hidden-expected.txt: Added.
     81        * web-platform-tests/intersection-observer/zero-area-element-hidden.html: Added.
     82        * web-platform-tests/intersection-observer/zero-area-element-visible-expected.txt: Added.
     83        * web-platform-tests/intersection-observer/zero-area-element-visible.html: Added.
     84
    1852018-08-08  Charlie Turner  <cturner@igalia.com>
    286

  • trunk/LayoutTests/imported/w3c/resources/import-expectations.json

    r233463 r234723  
    247247    "web-platform-tests/input-events": "skip",
    248248    "web-platform-tests/interfaces": "skip",
    249     "web-platform-tests/intersection-observer": "skip",
     249    "web-platform-tests/intersection-observer": "import",
    250250    "web-platform-tests/js": "skip",
    251251    "web-platform-tests/keyboard-lock": "skip",

  • trunk/Source/WebKit/ChangeLog

    r234719 r234723  
     12018-08-09  Ali Juma  <ajuma@chromium.org>
     2
     3        Import WPTs for IntersectionObserver
     4        https://bugs.webkit.org/show_bug.cgi?id=188416
     5
     6        Reviewed by Simon Fraser.
     7
     8        Make IntersectionObserver an experimental feature, so that it is enabled in
     9        WebKitTestRunner.
     10
     11        * Shared/WebPreferences.yaml:
     12
    1132018-08-08  Tim Horton  <timothy_horton@apple.com>
    214

  • trunk/Source/WebKit/Shared/WebPreferences.yaml

    r234482 r234723  
    655655  defaultValue: false
    656656  webcoreBinding: RuntimeEnabledFeatures
    657 
    658 IntersectionObserverEnabled:
    659   type: bool
    660   defaultValue: false
    661   humanReadableName: "Intersection Observer"
    662   humanReadableDescription: "Enable Intersection Observer support"
    663   webcoreBinding: RuntimeEnabledFeatures
    664   condition: ENABLE(INTERSECTION_OBSERVER)
    665657
    666658InteractiveFormValidationEnabled:
    … …  
    11471139  webcoreBinding: RuntimeEnabledFeatures
    11481140
     1141IntersectionObserverEnabled:
     1142  type: bool
     1143  defaultValue: false
     1144  humanReadableName: "Intersection Observer"
     1145  humanReadableDescription: "Enable Intersection Observer support"
     1146  webcoreBinding: RuntimeEnabledFeatures
     1147  category: experimental
     1148  condition: ENABLE(INTERSECTION_OBSERVER)
     1149
    11491150WebRTCLegacyAPIEnabled:
    11501151  type: bool

  • trunk/Source/WebKitLegacy/mac/ChangeLog

    r234693 r234723  
     12018-08-09  Ali Juma  <ajuma@chromium.org>
     2
     3        Import WPTs for IntersectionObserver
     4        https://bugs.webkit.org/show_bug.cgi?id=188416
     5
     6        Reviewed by Simon Fraser.
     7
     8        * WebView/WebPreferencesPrivate.h:
     9
    1102018-08-08  Jonathan Bedard  <jbedard@apple.com>
    211

  • trunk/Source/WebKitLegacy/mac/WebView/WebPreferencesPrivate.h

    r234482 r234723  
    576576- (void)setWebAuthenticationEnabled:(BOOL)flag;
    577577- (BOOL)webAuthenticationEnabled;
     578
     579- (void)setIntersectionObserverEnabled:(BOOL)flag;
     580- (BOOL)intersectionObserverEnabled;
    578581
    579582- (void)setIsSecureContextAttributeEnabled:(BOOL)flag;

  • trunk/Tools/ChangeLog

    r234720 r234723  
     12018-08-09  Ali Juma  <ajuma@chromium.org>
     2
     3        Import WPTs for IntersectionObserver
     4        https://bugs.webkit.org/show_bug.cgi?id=188416
     5
     6        Reviewed by Simon Fraser.
     7
     8        Enable IntersectionObserver in DumpRenderTree.
     9
     10        * DumpRenderTree/mac/DumpRenderTree.mm:
     11        (enableExperimentalFeatures):
     12        (setWebPreferencesForTestOptions):
     13        * WebKitTestRunner/TestController.cpp:
     14        (WTR::TestController::resetPreferencesToConsistentValues):
     15
    1162018-08-08  Ross Kirsling  <ross.kirsling@sony.com>
    217

  • trunk/Tools/DumpRenderTree/mac/DumpRenderTree.mm

    r234685 r234723  
    868868    [preferences setCrossOriginWindowPolicySupportEnabled:YES];
    869869    [preferences setServerTimingEnabled:YES];
     870    [preferences setIntersectionObserverEnabled:YES];
    870871}
    871872
    … …  
    997998    preferences.attachmentElementEnabled = options.enableAttachmentElement;
    998999    preferences.acceleratedDrawingEnabled = options.useAcceleratedDrawing;
    999     preferences.intersectionObserverEnabled = options.enableIntersectionObserver;
    10001000    preferences.menuItemElementEnabled = options.enableMenuItemElement;
    10011001    preferences.modernMediaControlsEnabled = options.enableModernMediaControls;

  • trunk/Tools/WebKitTestRunner/TestController.cpp

    r234501 r234723  
    712712    WKPreferencesSetNeedsSiteSpecificQuirks(preferences, options.needsSiteSpecificQuirks);
    713713    WKPreferencesSetAttachmentElementEnabled(preferences, options.enableAttachmentElement);
    714     WKPreferencesSetIntersectionObserverEnabled(preferences, options.enableIntersectionObserver);
    715714    WKPreferencesSetMenuItemElementEnabled(preferences, options.enableMenuItemElement);
    716715    WKPreferencesSetModernMediaControlsEnabled(preferences, options.enableModernMediaControls);
Note: See TracChangeset for help on using the changeset viewer.