Changeset 234832 in webkit

Timestamp:

Aug 13, 2018 5:58:40 PM (6 years ago)

Author:

jonlee@apple.com

Message:

[MotionMark] Update Multiply test
​https://bugs.webkit.org/show_bug.cgi?id=188532
<rdar://problem/43252151>

Reviewed by Said Abou-Hallawa.

Update Multiply test to have a larger upper limit of number of particles. Cycle through three
different ways of hiding an element. Add new Multiple suite that isolates those components for
debugging purposes.

• MotionMark/resources/debug-runner/tests.js:
• MotionMark/tests/dom/multiply.html: Added.
• MotionMark/tests/dom/resources/multiply.js: Added.
• MotionMark/tests/master/resources/multiply.js:

Location:

trunk/PerformanceTests

Files:

• ChangeLog (modified) (1 diff)
• MotionMark/resources/debug-runner/tests.js (modified) (1 diff)
• MotionMark/tests/dom/multiply.html (added)
• MotionMark/tests/dom/resources/multiply.js (added)
• MotionMark/tests/master/resources/multiply.js (modified) (5 diffs)

trunk/PerformanceTests/ChangeLog

@@ +1 @@
+2018-08-13  Jon Lee  <jonlee@apple.com>
+
+        [MotionMark] Update Multiply test
+        https://bugs.webkit.org/show_bug.cgi?id=188532
+        <rdar://problem/43252151>
+
+        Reviewed by Said Abou-Hallawa.
+
+        Update Multiply test to have a larger upper limit of number of particles. Cycle through three
+        different ways of hiding an element. Add new Multiple suite that isolates those components for
+        debugging purposes.
+
+        * MotionMark/resources/debug-runner/tests.js:
+        * MotionMark/tests/dom/multiply.html: Added.
+        * MotionMark/tests/dom/resources/multiply.js: Added.
+        * MotionMark/tests/master/resources/multiply.js:
+
 2018-08-13  Jon Lee  <jonlee@apple.com>
 

trunk/PerformanceTests/MotionMark/resources/debug-runner/tests.js

@@ -281 +281 @@
 ));
 
+Suites.push(new Suite("Multiply suite",
+    [
+        {
+            url: "dom/multiply.html?style=opacity",
+            name: "Multiply: CSS opacity only"
+        },
+        {
+            url: "dom/multiply.html?style=display",
+            name: "Multiply: CSS display only"
+        },
+        {
+            url: "dom/multiply.html?style=visibility",
+            name: "Multiply: CSS visibility only"
+        }
+    ]
+));
+
 Suites.push(new Suite("Text suite",
     [

trunk/PerformanceTests/MotionMark/tests/master/resources/multiply.js

@@ -33 +33 @@
     }, {
 
+    visibleCSS: [
+        ["visibility", "hidden", "visible"],
+        ["opacity", 0, 1],
+        ["display", "none", "block"]
+    ],
+    totalRows: 45,
+
     initialize: function(benchmark, options)
     {
         Stage.prototype.initialize.call(this, benchmark, options);
-        var tileSize = Math.round(this.size.height / 25);
+        var tileSize = Math.round(this.size.height / this.totalRows);
+        if (options.visibleCSS)
+            this.visibleCSS = options.visibleCSS;
 
         // Fill the scene with elements
@@ -84 +93 @@
         tile.style.width = tileSize + 'px';
         tile.style.height = tileSize + 'px';
-        tile.style.visibility = "hidden";
+        var visibleCSS = this.visibleCSS[this.tiles.length % this.visibleCSS.length];
+        tile.style[visibleCSS[0]] = visibleCSS[1];
 
         var distance = 1 / tileSize * this.size.multiply(0.5).subtract(new Point(x + halfTileSize, y + halfTileSize)).length();
@@ -92 +102 @@
             step: Math.max(3, distance / 1.5),
             distance: distance,
-            active: false
+            active: false,
+            visibleCSS: visibleCSS,
         });
     },
@@ -117 +128 @@
             var tile = this.tiles[i];
             tile.active = true;
-            tile.element.style.visibility = "";
+            tile.element.style[tile.visibleCSS[0]] = tile.visibleCSS[2];
             tile.rotate += tile.step;
             tile.element.style.transform = "rotate(" + tile.rotate + "deg)";
@@ -126 +137 @@
 
         for (var i = this._offsetIndex; i < this.tiles.length && this.tiles[i].active; ++i) {
-            this.tiles[i].active = false;
-            this.tiles[i].element.style.visibility = "hidden";
+            var tile = this.tiles[i];
+            tile.active = false;
+            tile.element.style[tile.visibleCSS[0]] = tile.visibleCSS[1];
         }
     }