Changeset 234922 in webkit


Ignore:
Timestamp:
Aug 16, 2018 7:28:34 AM (6 years ago)
Author:
Alan Bujtas
Message:

[LFC] Bail out of subtree verification when trees are out of sync.
https://bugs.webkit.org/show_bug.cgi?id=188633

Reviewed by Antti Koivisto.

There's no point of trying to match geometry when subtrees are out of sync.
They get out of sync when the render tree has unsupported boxes (see LayoutTreeBuilder).

  • layout/Verification.cpp:

(WebCore::Layout::verifyAndOutputSubtree):

Location:
trunk/Source/WebCore
Files:
2 edited

Legend:

Unmodified
Added
Removed
  • trunk/Source/WebCore/ChangeLog

    r234920 r234922  
     12018-08-16  Zalan Bujtas  <zalan@apple.com>
     2
     3        [LFC] Bail out of subtree verification when trees are out of sync.
     4        https://bugs.webkit.org/show_bug.cgi?id=188633
     5
     6        Reviewed by Antti Koivisto.
     7
     8        There's no point of trying to match geometry when subtrees are out of sync.
     9        They get out of sync when the render tree has unsupported boxes (see LayoutTreeBuilder).
     10
     11        * layout/Verification.cpp:
     12        (WebCore::Layout::verifyAndOutputSubtree):
     13
    1142018-08-16  Antti Koivisto  <antti@apple.com>
    215
  • trunk/Source/WebCore/layout/Verification.cpp

    r234544 r234922  
    171171        }
    172172
     173        if (!childBox) {
     174            stream  << "Trees are out of sync!";
     175            stream.nextLine();
     176            return true;
     177        }
     178
    173179        if (is<RenderBlockFlow>(*childRenderer) && childBox->establishesInlineFormattingContext()) {
    174180            ASSERT(childRenderer->childrenInline());
     
    184190        childRenderer = childRenderer->nextSibling();
    185191    }
     192
    186193    return mismtachingGeometry;
    187194}
Note: See TracChangeset for help on using the changeset viewer.