Changeset 235087 in webkit

Timestamp:

Aug 20, 2018 11:38:05 AM (6 years ago)

Author:

commit-queue@webkit.org

Message:

UIWebView crashes while attempting to play youtube video on phone
​https://bugs.webkit.org/show_bug.cgi?id=188351
rdar://problem/42489664

Patch by Jeremy Jones <​jeremyj@apple.com> on 2018-08-20
Reviewed by David Kilzer.

Test will be incorporated with fix for 188749, which will test both fixes.

VideoFullscreenControllerContext must remove unretained reference to it from m_playbackModel during cleanup.

• platform/ios/WebVideoFullscreenControllerAVKit.mm:

(VideoFullscreenControllerContext::didCleanupFullscreen):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• platform/ios/WebVideoFullscreenControllerAVKit.mm (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2018-08-20  Jeremy Jones  <jeremyj@apple.com>
+
+        UIWebView crashes while attempting to play youtube video on phone
+        https://bugs.webkit.org/show_bug.cgi?id=188351
+        rdar://problem/42489664
+
+        Reviewed by David Kilzer.
+
+        Test will be incorporated with fix for 188749, which will test both fixes.
+
+        VideoFullscreenControllerContext must remove unretained reference to it from m_playbackModel during cleanup.
+
+        * platform/ios/WebVideoFullscreenControllerAVKit.mm:
+        (VideoFullscreenControllerContext::didCleanupFullscreen):
+
 2018-08-20  Eric Carlson  <eric.carlson@apple.com>
 

trunk/Source/WebCore/platform/ios/WebVideoFullscreenControllerAVKit.mm

@@ -329 +329 @@
         m_fullscreenModel->setVideoElement(nullptr);
         m_playbackModel->setMediaElement(nullptr);
+        m_playbackModel->removeClient(*this);
         m_fullscreenModel->removeClient(*this);
         m_fullscreenModel = nullptr;