Changeset 235113 in webkit

Timestamp:

Aug 21, 2018 6:27:42 AM (6 years ago)

Author:

Carlos Garcia Campos

Message:

[Linux] Cache the memory footprint and only update it after 1 second
​https://bugs.webkit.org/show_bug.cgi?id=188791

Reviewed by Yusuke Suzuki.

Getting the memory footprint is an expensive operation in Linux. When called multiple times, the CPU usage is
too much (see bug #188787). We could cache the result for at least 1 second to ensure we don't call it more than
once per second.

• wtf/linux/MemoryFootprintLinux.cpp:

(WTF::forEachLine):
(WTF::computeMemoryFootprint):
(WTF::memoryFootprint):

Location:

trunk/Source/WTF

Files:

• ChangeLog (modified) (1 diff)
• wtf/linux/MemoryFootprintLinux.cpp (modified) (4 diffs)

trunk/Source/WTF/ChangeLog

@@ +1 @@
+2018-08-21  Carlos Garcia Campos  <cgarcia@igalia.com>
+
+        [Linux] Cache the memory footprint and only update it after 1 second
+        https://bugs.webkit.org/show_bug.cgi?id=188791
+
+        Reviewed by Yusuke Suzuki.
+
+        Getting the memory footprint is an expensive operation in Linux. When called multiple times, the CPU usage is
+        too much (see bug #188787). We could cache the result for at least 1 second to ensure we don't call it more than
+        once per second.
+
+        * wtf/linux/MemoryFootprintLinux.cpp:
+        (WTF::forEachLine):
+        (WTF::computeMemoryFootprint):
+        (WTF::memoryFootprint):
+
 2018-08-20  Saam barati  <sbarati@apple.com>
 

trunk/Source/WTF/wtf/linux/MemoryFootprintLinux.cpp

@@ -28 +28 @@
 
 #if OS(LINUX)
+#include "MonotonicTime.h"
 #include <stdio.h>
 #include <wtf/StdLibExtras.h>
@@ -36 +37 @@
 
 #if OS(LINUX)
+static const Seconds s_memoryFootprintUpdateInterval = 1_s;
+
 template<typename Functor>
 static void forEachLine(FILE* file, Functor functor)
@@ -46 +49 @@
     free(buffer);
 }
-#endif
 
-size_t memoryFootprint()
+static size_t computeMemoryFootprint()
 {
-#if OS(LINUX)
     FILE* file = fopen("/proc/self/smaps", "r");
     if (!file)
@@ -87 +88 @@
     fclose(file);
     return totalPrivateDirtyInKB * KB;
+}
+#endif
+
+size_t memoryFootprint()
+{
+#if OS(LINUX)
+    static size_t footprint = 0;
+    static MonotonicTime previousUpdateTime = { };
+    Seconds elapsed = MonotonicTime::now() - previousUpdateTime;
+    if (elapsed >= s_memoryFootprintUpdateInterval) {
+        footprint = computeMemoryFootprint();
+        previousUpdateTime = MonotonicTime::now();
+    }
+
+    return footprint;
 #endif
     return 0;