Changeset 235115 in webkit


Ignore:
Timestamp:
Aug 21, 2018 6:55:13 AM (6 years ago)
Author:
Fujii Hironori
Message:

Don't place "using namespace XXX;" in global space for unified source builds
​https://bugs.webkit.org/show_bug.cgi?id=188739

Reviewed by Yusuke Suzuki.

No new tests (No behavior change).

  • html/track/AudioTrackList.cpp:
  • html/track/TextTrackList.cpp:
  • html/track/VideoTrackList.cpp:
  • page/SecurityOriginData.cpp:
  • page/TextIndicator.cpp:
  • platform/geoclue/GeolocationProviderGeoclue.cpp:
  • platform/graphics/gstreamer/ImageGStreamerCairo.cpp:
  • platform/graphics/win/FullScreenController.cpp:
  • platform/mediastream/CaptureDeviceManager.cpp:
  • platform/mock/MediaPlaybackTargetPickerMock.cpp:
  • svg/animation/SMILTime.cpp:
  • testing/js/WebCoreTestSupport.cpp:
  • xml/XPathParser.cpp:
Location:
trunk/Source/WebCore
Files:
14 edited

Legend:

Unmodified
Added
Removed

  • trunk/Source/WebCore/ChangeLog

    r235112 r235115  
     12018-08-21  Fujii Hironori  <Hironori.Fujii@sony.com>
     2
     3        Don't place "using namespace XXX;" in global space for unified source builds
     4        https://bugs.webkit.org/show_bug.cgi?id=188739
     5
     6        Reviewed by Yusuke Suzuki.
     7
     8        No new tests (No behavior change).
     9
     10        * html/track/AudioTrackList.cpp:
     11        * html/track/TextTrackList.cpp:
     12        * html/track/VideoTrackList.cpp:
     13        * page/SecurityOriginData.cpp:
     14        * page/TextIndicator.cpp:
     15        * platform/geoclue/GeolocationProviderGeoclue.cpp:
     16        * platform/graphics/gstreamer/ImageGStreamerCairo.cpp:
     17        * platform/graphics/win/FullScreenController.cpp:
     18        * platform/mediastream/CaptureDeviceManager.cpp:
     19        * platform/mock/MediaPlaybackTargetPickerMock.cpp:
     20        * svg/animation/SMILTime.cpp:
     21        * testing/js/WebCoreTestSupport.cpp:
     22        * xml/XPathParser.cpp:
     23
    1242018-08-21  Philippe Normand  <philn@igalia.com>
    225

  • trunk/Source/WebCore/html/track/AudioTrackList.cpp

    r234374 r235115  
    3232#include "AudioTrack.h"
    3333
    34 using namespace WebCore;
     34namespace WebCore {
    3535
    3636AudioTrackList::AudioTrackList(HTMLMediaElement* element, ScriptExecutionContext* context)
    … …  
    8787}
    8888
     89} // namespace WebCore
    8990#endif

  • trunk/Source/WebCore/html/track/TextTrackList.cpp

    r234374 r235115  
    3535#include "LoadableTextTrack.h"
    3636
    37 using namespace WebCore;
     37namespace WebCore {
    3838
    3939TextTrackList::TextTrackList(HTMLMediaElement* element, ScriptExecutionContext* context)
    … …  
    271271}
    272272
     273} // namespace WebCore
    273274#endif

  • trunk/Source/WebCore/html/track/VideoTrackList.cpp

    r234374 r235115  
    3232#include "VideoTrack.h"
    3333
    34 using namespace WebCore;
     34namespace WebCore {
    3535
    3636VideoTrackList::VideoTrackList(HTMLMediaElement* element, ScriptExecutionContext* context)
    … …  
    100100}
    101101
     102} // namespace WebCore
    102103#endif

  • trunk/Source/WebCore/page/SecurityOriginData.cpp

    r233122 r235115  
    3434#include <wtf/text/StringBuilder.h>
    3535#include <wtf/text/StringConcatenateNumbers.h>
    36 
    37 using namespace WebCore;
    3836
    3937namespace WebCore {

  • trunk/Source/WebCore/page/TextIndicator.cpp

    r234801 r235115  
    5151#endif
    5252
    53 using namespace WebCore;
    54 
    5553namespace WebCore {
    5654

  • trunk/Source/WebCore/platform/geoclue/GeolocationProviderGeoclue.cpp

    r221132 r235115  
    3636const char* gGeoclueManagerPath = "/org/freedesktop/GeoClue2/Manager";
    3737
    38 using namespace WebCore;
     38namespace WebCore {
    3939
    4040typedef enum {
    … …  
    211211}
    212212
     213} // namespace WebCore
     214
    213215#endif // ENABLE(GEOLOCATION)

  • trunk/Source/WebCore/platform/graphics/gstreamer/ImageGStreamerCairo.cpp

    r232795 r235115  
    3030
    3131
    32 using namespace WebCore;
     32namespace WebCore {
    3333
    3434ImageGStreamer::ImageGStreamer(GstSample* sample)
    … …  
    118118        gst_video_frame_unmap(&m_videoFrame);
    119119}
     120
     121} // namespace WebCore
     122
    120123#endif // USE(GSTREAMER)

  • trunk/Source/WebCore/platform/graphics/win/FullScreenController.cpp

    r223728 r235115  
    3939#include <wtf/RefPtr.h>
    4040
    41 using namespace WebCore;
     41namespace WebCore {
    4242
    4343static const int kFullScreenAnimationDuration = 500; // milliseconds
    … …  
    218218    m_private->m_backgroundWindow = nullptr;
    219219}
     220
     221} // namespace WebCore
     222
    220223#endif

  • trunk/Source/WebCore/platform/mediastream/CaptureDeviceManager.cpp

    r235086 r235115  
    3737#include <wtf/text/StringHash.h>
    3838
    39 using namespace WebCore;
     39namespace WebCore {
    4040
    4141CaptureDeviceManager::~CaptureDeviceManager() = default;
    … …  
    6161}
    6262
     63} // namespace WebCore
     64
    6365#endif // ENABLE(MEDIA_STREAM)

  • trunk/Source/WebCore/platform/mock/MediaPlaybackTargetPickerMock.cpp

    r233552 r235115  
    3333#include "MediaPlaybackTargetMock.h"
    3434#include "WebMediaSessionManager.h"
    35 
    36 using namespace WebCore;
    3735
    3836namespace WebCore {

  • trunk/Source/WebCore/svg/animation/SMILTime.cpp

    r163440 r235115  
    2929#include <float.h>
    3030
    31 using namespace WebCore;
     31namespace WebCore {
    3232
    3333const double SMILTime::unresolvedValue = DBL_MAX;
    … …  
    3535const double SMILTime::indefiniteValue = FLT_MAX;   
    3636
    37 SMILTime WebCore::operator+(const SMILTime& a, const SMILTime& b)
     37SMILTime operator+(const SMILTime& a, const SMILTime& b)
    3838{
    3939    if (a.isUnresolved() || b.isUnresolved())
    … …  
    4444}
    4545
    46 SMILTime WebCore::operator-(const SMILTime& a, const SMILTime& b)
     46SMILTime operator-(const SMILTime& a, const SMILTime& b)
    4747{
    4848    if (a.isUnresolved() || b.isUnresolved())
    … …  
    5353}
    5454
    55 SMILTime WebCore::operator*(const SMILTime& a,  const SMILTime& b)
     55SMILTime operator*(const SMILTime& a,  const SMILTime& b)
    5656{
    5757    if (a.isUnresolved() || b.isUnresolved())
    … …  
    6363    return a.value() * b.value();
    6464}
     65
     66} // namespace WebCore

  • trunk/Source/WebCore/testing/js/WebCoreTestSupport.cpp

    r232337 r235115  
    4747#include <JavaScriptCore/JSValueRef.h>
    4848
    49 using namespace WebCore;
    50 
    5149namespace WebCoreTestSupport {
    5250using namespace JSC;
     51using namespace WebCore;
    5352
    5453void injectInternalsObject(JSContextRef context)

  • trunk/Source/WebCore/xml/XPathParser.cpp

    r223476 r235115  
    3838
    3939extern int xpathyyparse(WebCore::XPath::Parser&);
    40 
    41 using namespace WebCore;
    42 using namespace XPath;
    4340
    4441#include "XPathGrammar.h"
Note: See TracChangeset for help on using the changeset viewer.