Changeset 235142 in webkit
- Timestamp:
- Aug 21, 2018 3:08:18 PM (6 years ago)
- Location:
- trunk/Source/WebInspectorUI
- Files:
-
- 3 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/Source/WebInspectorUI/ChangeLog
r235141 r235142 1 2018-08-21 Devin Rousso <drousso@apple.com> 2 3 Web Inspector: REGRESSION(r235095): duplicate actions existing in WI.CanvasSidebarPanel 4 https://bugs.webkit.org/show_bug.cgi?id=188808 5 6 Reviewed by Joseph Pecoraro. 7 8 * UserInterface/Views/CanvasSidebarPanel.js: 9 (WI.CanvasSidebarPanel.prototype._recordingChanged): 10 Check that the `WI.RecordingAction` is not already represented in the `WI.TreeOutline` 11 before adding it. 12 13 * UserInterface/Views/CanvasSidebarPanel.css: 14 (.sidebar > .panel.navigation.canvas > .content > .recording-content > .tree-outline .item.processing .subtitle > progress): 15 Drive-by: vertically center the <progress> shown for `WI.RecordingFrame` during processing. 16 1 17 2018-08-21 Devin Rousso <drousso@apple.com> 2 18 -
trunk/Source/WebInspectorUI/UserInterface/Views/CanvasSidebarPanel.css
r235095 r235142 76 76 width: 100%; 77 77 max-width: 100px; 78 margin: 2px 4px 0; 78 margin: 0 4px; 79 vertical-align: -3px; 79 80 } 80 81 -
trunk/Source/WebInspectorUI/UserInterface/Views/CanvasSidebarPanel.js
r235095 r235142 408 408 } 409 409 410 if (this._recording.actions[0].ready) { 411 this._recordingTreeOutline.appendChild(new WI.RecordingActionTreeElement(this._recording.actions[0], 0, this._recording.type)); 410 let initialStateAction = this._recording.actions[0]; 411 if (initialStateAction.ready && !this._recordingTreeOutline.getCachedTreeElement(initialStateAction)) { 412 this._recordingTreeOutline.appendChild(new WI.RecordingActionTreeElement(initialStateAction, 0, this._recording.type)); 412 413 413 414 if (!this._recording[WI.CanvasSidebarPanel.SelectedActionSymbol]) 414 this.action = this._recording.actions[0];415 this.action = initialStateAction; 415 416 } 416 417 … … 420 421 return; 421 422 422 let folder = this._createRecordingFrameTreeElement(frame, frameIndex, this._recordingTreeOutline); 423 let folder = this._recordingTreeOutline.getCachedTreeElement(frame); 424 if (!folder) 425 folder = this._createRecordingFrameTreeElement(frame, frameIndex, this._recordingTreeOutline); 423 426 424 427 for (let action of frame.actions) { 425 if (!action.ready) 428 ++cumulativeActionIndex; 429 430 if (!action.ready || this._recordingTreeOutline.getCachedTreeElement(action)) 426 431 break; 427 428 ++cumulativeActionIndex;429 432 430 433 this._createRecordingActionTreeElement(action, cumulativeActionIndex, folder);
Note: See TracChangeset
for help on using the changeset viewer.