Changeset 235274 in webkit

Timestamp:

Aug 23, 2018 10:51:34 PM (6 years ago)

Author:

rniwa@webkit.org

Message:

fast/files/blob-network-process-crash.html is flaky
​https://bugs.webkit.org/show_bug.cgi?id=188911

Reviewed by Saam Barati.

The flakiness appears to come from the web content process not getting notified of
the termination of the network process in time. Wait for the network process to
relaunch after terminating one by continuously fetch'ing itself with an increasing
time interval until it succeeds.

• fast/files/blob-network-process-crash.html:

Location:

trunk/LayoutTests

Files:

• ChangeLog (modified) (1 diff)
• fast/files/blob-network-process-crash.html (modified) (2 diffs)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2018-08-23  Ryosuke Niwa  <rniwa@webkit.org>
+
+        fast/files/blob-network-process-crash.html is flaky
+        https://bugs.webkit.org/show_bug.cgi?id=188911
+
+        Reviewed by Saam Barati.
+
+        The flakiness appears to come from the web content process not getting notified of
+        the termination of the network process in time. Wait for the network process to
+        relaunch after terminating one by continuously fetch'ing itself with an increasing
+        time interval until it succeeds.
+
+        * fast/files/blob-network-process-crash.html:
+
 2018-08-23  Ryosuke Niwa  <rniwa@webkit.org>
 

trunk/LayoutTests/fast/files/blob-network-process-crash.html

@@ -8 +8 @@
 if (!window.testRunner)
     document.write('This test requires testRunner and GCController');
-else {
+else
+    runTest();
+
+async function runTest()
+{
     testRunner.dumpAsText();
     testRunner.waitUntilDone();
@@ -21 +25 @@
     testRunner.terminateNetworkProcess();
 
-    // FIXME: If we don't store the timer, timer sometimes never fires.
-    window.timer = setTimeout(() => {
-        const newBlob = new Blob(["some text"]);
-        for (let i = 0; i < 100; i++) {
-            for (let j = 0; j < 10; j++)
-                blobs[i][j] = { };
-        }
-        blobs = null;
-        GCController.collect();
-        fetch('blob-network-process-crash.html').then(() => {
-            testRunner.notifyDone();
-        });
-    }, 0);
+    await waitForNetworkProcessToRelaunch();
+    const newBlob = new Blob(["some text"]);
+    for (let i = 0; i < 100; i++) {
+        for (let j = 0; j < 10; j++)
+            blobs[i][j] = { };
+    }
+    blobs = null;
+    GCController.collect();
+
+    await fetch('blob-network-process-crash.html');
+
+    testRunner.notifyDone();
+}
+
+let waitTime = 10;
+function waitForNetworkProcessToRelaunch() {
+    return fetch('blob-network-process-crash.html').catch(() => {
+        return new Promise((resolve, reject) => {
+            waitTime *= 1.2;
+            setTimeout(() => waitForNetworkProcessToRelaunch().then(resolve), waitTime);
+        })
+    });
 }