Changeset 235321 in webkit

Timestamp:

Aug 24, 2018 10:46:01 AM (6 years ago)

Author:

sihui_liu@apple.com

Message:

Don't launch network process in WebCookieManagerProxy::setHTTPCookieAcceptPolicy
​https://bugs.webkit.org/show_bug.cgi?id=188906
<rdar://problem/43539661>

Reviewed by Geoffrey Garen.

In WebCookieManagerProxy::setHTTPCookieAcceptPolicy, we persist the cookieAcceptPolicy of
sharedCookieStorage. When we launch the network process later, we pass the
identifier of sharedCookieStorage to network process, so network process has the correct
cookieAcceptPolicy. Therefore, we don't have to launch the network process and send the
setting message if the network process is not launched.

• UIProcess/WebCookieManagerProxy.cpp:

(WebKit::WebCookieManagerProxy::setHTTPCookieAcceptPolicy):

Location:

trunk/Source/WebKit

Files:

• ChangeLog (modified) (1 diff)
• UIProcess/WebCookieManagerProxy.cpp (modified) (1 diff)

trunk/Source/WebKit/ChangeLog

@@ +1 @@
+2018-08-24  Sihui Liu  <sihui_liu@apple.com>
+
+        Don't launch network process in WebCookieManagerProxy::setHTTPCookieAcceptPolicy
+        https://bugs.webkit.org/show_bug.cgi?id=188906
+        <rdar://problem/43539661>
+
+        Reviewed by Geoffrey Garen.
+
+        In WebCookieManagerProxy::setHTTPCookieAcceptPolicy, we persist the cookieAcceptPolicy of 
+        sharedCookieStorage. When we launch the network process later, we pass the 
+        identifier of sharedCookieStorage to network process, so network process has the correct 
+        cookieAcceptPolicy. Therefore, we don't have to launch the network process and send the 
+        setting message if the network process is not launched.
+
+        * UIProcess/WebCookieManagerProxy.cpp:
+        (WebKit::WebCookieManagerProxy::setHTTPCookieAcceptPolicy):
+
 2018-08-23  Carlos Garcia Campos  <cgarcia@igalia.com>
 

trunk/Source/WebKit/UIProcess/WebCookieManagerProxy.cpp

@@ -252 +252 @@
 #endif
 
+    if (!processPool()->networkProcess())
+        return;
+
     auto callbackID = m_callbacks.put(WTFMove(callbackFunction), processPool()->ensureNetworkProcess().throttler().backgroundActivityToken());
     processPool()->sendToNetworkingProcess(Messages::WebCookieManager::SetHTTPCookieAcceptPolicy(policy, OptionalCallbackID(callbackID)));