Changeset 235374 in webkit

Timestamp:

Aug 27, 2018 9:43:23 AM (6 years ago)

Author:

sihui_liu@apple.com

Message:

Don't launch network process in WebCookieManagerProxy::setHTTPCookieAcceptPolicy
​https://bugs.webkit.org/show_bug.cgi?id=188906
<rdar://problem/42875795>

Reviewed by Ryosuke Niwa.

Add callback in early return.

• UIProcess/WebCookieManagerProxy.cpp:

(WebKit::WebCookieManagerProxy::setHTTPCookieAcceptPolicy):

Location:

trunk/Source/WebKit

Files:

• ChangeLog (modified) (1 diff)
• UIProcess/WebCookieManagerProxy.cpp (modified) (1 diff)

trunk/Source/WebKit/ChangeLog

@@ +1 @@
+2018-08-27  Sihui Liu  <sihui_liu@apple.com>
+
+        Don't launch network process in WebCookieManagerProxy::setHTTPCookieAcceptPolicy
+        https://bugs.webkit.org/show_bug.cgi?id=188906
+        <rdar://problem/42875795>
+
+        Reviewed by Ryosuke Niwa.
+
+        Add callback in early return.
+
+        * UIProcess/WebCookieManagerProxy.cpp:
+        (WebKit::WebCookieManagerProxy::setHTTPCookieAcceptPolicy):
+
 2018-08-27  Alex Christensen  <achristensen@webkit.org>
 

trunk/Source/WebKit/UIProcess/WebCookieManagerProxy.cpp

@@ -252 +252 @@
 #endif
 
-    if (!processPool()->networkProcess())
-        return;
+    if (!processPool()->networkProcess()) {
+        callbackFunction(CallbackBase::Error::None);
+        return;
+    }
 
     auto callbackID = m_callbacks.put(WTFMove(callbackFunction), processPool()->ensureNetworkProcess().throttler().backgroundActivityToken());