Changeset 235377 in webkit

Timestamp:

Aug 27, 2018 9:59:39 AM (6 years ago)

Author:

Devin Rousso

Message:

Web Inspector: REGRESSION: virtualized TreeOutline is empty when filtering
​https://bugs.webkit.org/show_bug.cgi?id=188959

Reviewed by Brian Burg.

• UserInterface/Views/TreeElement.js:

(WI.TreeElement.prototype.set hidden):
Only set focusedTreeElement if the WI.TreeElement is selected and not hidden. There is
no reason to focus a hidden or unselected WI.TreeElement.

Location:

trunk/Source/WebInspectorUI

Files:

• ChangeLog (modified) (1 diff)
• UserInterface/Views/TreeElement.js (modified) (1 diff)

trunk/Source/WebInspectorUI/ChangeLog

@@ +1 @@
+2018-08-27  Devin Rousso  <drousso@apple.com>
+
+        Web Inspector: REGRESSION: virtualized TreeOutline is empty when filtering
+        https://bugs.webkit.org/show_bug.cgi?id=188959
+
+        Reviewed by Brian Burg.
+
+        * UserInterface/Views/TreeElement.js:
+        (WI.TreeElement.prototype.set hidden):
+        Only set `focusedTreeElement` if the `WI.TreeElement` is selected and not hidden. There is
+        no reason to focus a hidden or unselected `WI.TreeElement`.
+
 2018-08-23  Devin Rousso  <drousso@apple.com>
 

trunk/Source/WebInspectorUI/UserInterface/Views/TreeElement.js

@@ -167 +167 @@
 
         if (this.treeOutline) {
-            this.treeOutline.soon.updateVirtualizedElements(this);
+            let focusedTreeElement = null;
+            if (!this._hidden && this.selected)
+                focusedTreeElement = this;
+            this.treeOutline.soon.updateVirtualizedElements(focusedTreeElement);
 
             this.treeOutline.dispatchEventToListeners(WI.TreeOutline.Event.ElementVisibilityDidChange, {element: this});