Changeset 235508 in webkit

Timestamp:

Aug 30, 2018 9:53:01 AM (6 years ago)

Author:

youenn@apple.com

Message:

fast/mediastream/RTCPeerConnection-overloaded-operations.html is flaky after r235484
​https://bugs.webkit.org/show_bug.cgi?id=189155

Reviewed by Eric Carlson.

• fast/mediastream/RTCPeerConnection-overloaded-operations.html:

createOffer/createAnswer will now reject promises if callbacks are passed as parameters.
Make sure that these promises are handled.

Location:

trunk/LayoutTests

Files:

• ChangeLog (modified) (1 diff)
• fast/mediastream/RTCPeerConnection-overloaded-operations.html (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2018-08-30  Youenn Fablet  <youenn@apple.com>
+
+        fast/mediastream/RTCPeerConnection-overloaded-operations.html is flaky after r235484
+        https://bugs.webkit.org/show_bug.cgi?id=189155
+
+        Reviewed by Eric Carlson.
+
+        * fast/mediastream/RTCPeerConnection-overloaded-operations.html:
+        createOffer/createAnswer will now reject promises if callbacks are passed as parameters.
+        Make sure that these promises are handled.
+
 2018-08-30  Zalan Bujtas  <zalan@apple.com>
 

trunk/LayoutTests/fast/mediastream/RTCPeerConnection-overloaded-operations.html

@@ -28 +28 @@
                 shouldNotThrow("result = pc." + functionName + "(emptyFunc, emptyFunc)");
                 shouldBeType("result", "Promise");
+                result.then(() => { }, () => { });
 
                 shouldNotThrow("result = pc." + functionName + "(emptyFunc, emptyFunc, {})");
                 shouldBeType("result", "Promise");
+                result.then(() => { }, () => { });
             }