Changeset 235524 in webkit

Timestamp:

Aug 30, 2018 2:33:38 PM (6 years ago)

Author:

commit-queue@webkit.org

Message:

REGRESSION(r235489): fast/dom/navigator-detached-no-crash.html crashes under Navigator::share
​https://bugs.webkit.org/show_bug.cgi?id=189170

Patch by Olivia Barnett <​obarnett@apple.com> on 2018-08-30
Reviewed by Tim Horton.

No new tests; fixing a failing existing test.

• page/Navigator.cpp:

(WebCore::Navigator::share):
Added null check for frame.

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• page/Navigator.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2018-08-30  Olivia Barnett  <obarnett@apple.com>
+
+        REGRESSION(r235489): fast/dom/navigator-detached-no-crash.html crashes under Navigator::share
+        https://bugs.webkit.org/show_bug.cgi?id=189170
+
+        Reviewed by Tim Horton.
+
+        No new tests; fixing a failing existing test.
+
+        * page/Navigator.cpp:
+        (WebCore::Navigator::share):
+        Added null check for frame.
+
 2018-08-30  Truitt Savell  <tsavell@apple.com>
 

trunk/Source/WebCore/page/Navigator.cpp

@@ -100 +100 @@
 void Navigator::share(ScriptExecutionContext& context, ShareData data, Ref<DeferredPromise>&& promise)
 {
-    if (!m_frame->page()) {
+    if (!m_frame || !m_frame->page()) {
         promise->reject(TypeError);
         return;