Changeset 235614 in webkit

Timestamp:

Sep 4, 2018 10:01:55 AM (6 years ago)

Author:

jer.noble@apple.com

Message:

REGRESSION (r234081): TestWebKitAPI.VideoControlsManager.VideoControlsManagerAudioElementFollowingUserInteraction is a flaky timeout
​https://bugs.webkit.org/show_bug.cgi?id=187972
<rdar://problem/42667737>

Reviewed by Darin Adler.

Ensure that listeners are added in time to catch messages broadcast at them.

• TestWebKitAPI/Tests/WebKitCocoa/VideoControlsManager.mm:

(TestWebKitAPI::TEST):

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• TestWebKitAPI/Tests/WebKitCocoa/VideoControlsManager.mm (modified) (2 diffs)

trunk/Tools/ChangeLog

@@ +1 @@
+2018-09-04  Jer Noble  <jer.noble@apple.com>
+
+        REGRESSION (r234081): TestWebKitAPI.VideoControlsManager.VideoControlsManagerAudioElementFollowingUserInteraction is a flaky timeout
+        https://bugs.webkit.org/show_bug.cgi?id=187972
+        <rdar://problem/42667737>
+
+        Reviewed by Darin Adler.
+
+        Ensure that listeners are added in time to catch messages broadcast at them.
+
+        * TestWebKitAPI/Tests/WebKitCocoa/VideoControlsManager.mm:
+        (TestWebKitAPI::TEST):
+
 2018-09-04  Ross Kirsling  <ross.kirsling@sony.com>
 

trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/VideoControlsManager.mm

@@ -334 +334 @@
     [webView loadTestPageNamed:@"play-audio-on-click"];
     [webView waitForPageToLoadWithAutoplayingVideos:0];
-    [webView mouseDownAtPoint:NSMakePoint(200, 200) simulatePressure:YES];
 
     [webView performAfterReceivingMessage:@"playing-first" action:^ {
@@ -344 +343 @@
         secondAudioPlaying = true;
     }];
+
+    [webView mouseDownAtPoint:NSMakePoint(200, 200) simulatePressure:YES];
+
     TestWebKitAPI::Util::run(&secondAudioPlaying);
     while ([[NSRunLoop currentRunLoop] runMode:NSDefaultRunLoopMode beforeDate:[NSDate distantPast]]) {