Changeset 23565 in webkit

Timestamp:

Jun 18, 2007 9:55:20 AM (17 years ago)

Author:

bdash

Message:

2007-06-18 Mitz Pettel <​mitz@webkit.org>

Reviewed by Adele.

• fix ​http://bugs.webkit.org/show_bug.cgi?id=13413 Failed assertion in RenderTextControl::setSelectionRange in Google Spreadsheets

Test: fast/forms/input-zero-height-focus.html

• rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::setSelectionRange): Avoid setting the selection in a zero-height text control.

2007-06-18 Mitz Pettel <​mitz@webkit.org>

Reviewed by Adele.

• test for ​http://bugs.webkit.org/show_bug.cgi?id=13413 Failed assertion in RenderTextControl::setSelectionRange in Google Spreadsheets

• fast/forms/input-zero-height-focus-expected.txt: Added.
• fast/forms/input-zero-height-focus.html: Added.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/fast/forms/input-zero-height-focus-expected.txt (added)
• LayoutTests/fast/forms/input-zero-height-focus.html (added)
• WebCore/ChangeLog (modified) (1 diff)
• WebCore/rendering/RenderTextControl.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2007-06-18  Mitz Pettel  <mitz@webkit.org>
+
+        Reviewed by Adele.
+
+        - test for http://bugs.webkit.org/show_bug.cgi?id=13413
+          Failed assertion in RenderTextControl::setSelectionRange in Google Spreadsheets
+
+        * fast/forms/input-zero-height-focus-expected.txt: Added.
+        * fast/forms/input-zero-height-focus.html: Added.
+
 2007-06-15  Sam Weinig  <sam@webkit.org>
 

trunk/WebCore/ChangeLog

@@ +1 @@
+2007-06-18  Mitz Pettel  <mitz@webkit.org>
+
+        Reviewed by Adele.
+
+        - fix http://bugs.webkit.org/show_bug.cgi?id=13413
+          Failed assertion in RenderTextControl::setSelectionRange in Google Spreadsheets
+
+        Test: fast/forms/input-zero-height-focus.html
+
+        * rendering/RenderTextControl.cpp:
+        (WebCore::RenderTextControl::setSelectionRange): Avoid setting the
+        selection in a zero-height text control.
+
 2007-06-18  Alp Toker  <alp.toker@collabora.co.uk>
 

trunk/WebCore/rendering/RenderTextControl.cpp

@@ -422 +422 @@
     document()->updateLayout();
 
-    if (style()->visibility() == HIDDEN) {
+    if (style()->visibility() == HIDDEN || !m_innerText || !m_innerText->renderer() || !m_innerText->renderer()->height()) {
         if (m_multiLine)
             static_cast<HTMLTextAreaElement*>(node())->cacheSelection(start, end);