Changeset 235652 in webkit


Ignore:
Timestamp:
Sep 4, 2018 6:22:55 PM (6 years ago)
Author:
emilio
Message:

Remove PseudoElementUserAgentCustom.
​https://bugs.webkit.org/show_bug.cgi?id=189089

Reviewed by Ryosuke Niwa.

Tests at ​https://github.com/web-platform-tests/wpt/pull/12743.

  • css/CSSSelector.cpp:

(WebCore::CSSSelector::pseudoId):
(WebCore::CSSSelector::parsePseudoElementType):

  • css/CSSSelector.h:

(WebCore::CSSSelector::isCustomPseudoElement const):

  • css/RuleSet.cpp:

(WebCore::RuleSet::addRule):

  • css/parser/CSSParserSelector.h:

(WebCore::CSSParserSelector::needsImplicitShadowCombinatorForMatching const):

Location:
trunk/Source/WebCore
Files:
5 edited

Legend:

Unmodified
Added
Removed

  • trunk/Source/WebCore/ChangeLog

    r235651 r235652  
     12018-08-29  Emilio Cobos Álvarez  <emilio@crisal.io>
     2
     3        Remove PseudoElementUserAgentCustom.
     4        https://bugs.webkit.org/show_bug.cgi?id=189089
     5
     6        Reviewed by Ryosuke Niwa.
     7
     8        Tests at https://github.com/web-platform-tests/wpt/pull/12743.
     9
     10        * css/CSSSelector.cpp:
     11        (WebCore::CSSSelector::pseudoId):
     12        (WebCore::CSSSelector::parsePseudoElementType):
     13        * css/CSSSelector.h:
     14        (WebCore::CSSSelector::isCustomPseudoElement const):
     15        * css/RuleSet.cpp:
     16        (WebCore::RuleSet::addRule):
     17        * css/parser/CSSParserSelector.h:
     18        (WebCore::CSSParserSelector::needsImplicitShadowCombinatorForMatching const):
     19
    1202018-09-04  Dean Jackson  <dino@apple.com>
    221

  • trunk/Source/WebCore/css/CSSSelector.cpp

    r234877 r235652  
    300300    case PseudoElementSlotted:
    301301    case PseudoElementUnknown:
    302     case PseudoElementUserAgentCustom:
    303302    case PseudoElementWebKitCustom:
    304303    case PseudoElementWebKitCustomLegacyPrefixed:
    … …  
    319318        if (name.startsWith("-webkit-"))
    320319            type = PseudoElementWebKitCustom;
    321 
    322         if (name.startsWith("x-"))
    323             type = PseudoElementUserAgentCustom;
    324320    }
    325321    return type;

  • trunk/Source/WebCore/css/CSSSelector.h

    r234877 r235652  
    184184            PseudoElementSelection,
    185185            PseudoElementSlotted,
    186             PseudoElementUserAgentCustom,
    187186            PseudoElementWebKitCustom,
    188187
    … …  
    412411{
    413412    return match() == PseudoElement
    414         && (pseudoElementType() == PseudoElementUserAgentCustom
    415             || pseudoElementType() == PseudoElementWebKitCustom
     413        && (pseudoElementType() == PseudoElementWebKitCustom
    416414            || pseudoElementType() == PseudoElementWebKitCustomLegacyPrefixed);
    417415}

  • trunk/Source/WebCore/css/RuleSet.cpp

    r228313 r235652  
    243243        case CSSSelector::PseudoElement:
    244244            switch (selector->pseudoElementType()) {
    245             case CSSSelector::PseudoElementUserAgentCustom:
    246245            case CSSSelector::PseudoElementWebKitCustom:
    247246            case CSSSelector::PseudoElementWebKitCustomLegacyPrefixed:

  • trunk/Source/WebCore/css/parser/CSSParserSelector.h

    r234877 r235652  
    118118    return match() == CSSSelector::PseudoElement
    119119        && (pseudoElementType() == CSSSelector::PseudoElementWebKitCustom
    120             || pseudoElementType() == CSSSelector::PseudoElementUserAgentCustom
    121120#if ENABLE(VIDEO_TRACK)
    122121            || pseudoElementType() == CSSSelector::PseudoElementCue
Note: See TracChangeset for help on using the changeset viewer.