Changeset 235759 in webkit

Timestamp:

Sep 6, 2018 2:48:34 PM (6 years ago)

Author:

dbates@webkit.org

Message:

[iOS] Add a test to ensure that DOM keyup events have the correct details
​https://bugs.webkit.org/show_bug.cgi?id=189327

Reviewed by Wenson Hsieh.

Until we fix <rdar://problem/35282761> DOM keyup events will have incorrect details on iOS
when dispatched in response to a hardware keyboard press. For now, land expected failure results.

• fast/events/ios/keyup-expected.txt: Added.
• fast/events/ios/keyup.html: Added.
• resources/ui-helper.js:

(window.UIHelper.typeCharacter): Escape backslash characters in order to build up
a well-formed UI script to evaluate.

Location:

trunk/LayoutTests

Files:

• ChangeLog (modified) (1 diff)
• fast/events/ios/keyup-expected.txt (added)
• fast/events/ios/keyup.html (added)
• resources/ui-helper.js (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2018-09-06  Daniel Bates  <dabates@apple.com>
+
+        [iOS] Add a test to ensure that DOM keyup events have the correct details
+        https://bugs.webkit.org/show_bug.cgi?id=189327
+
+        Reviewed by Wenson Hsieh.
+
+        Until we fix <rdar://problem/35282761> DOM keyup events will have incorrect details on iOS
+        when dispatched in response to a hardware keyboard press. For now, land expected failure results.
+
+        * fast/events/ios/keyup-expected.txt: Added.
+        * fast/events/ios/keyup.html: Added.
+        * resources/ui-helper.js:
+        (window.UIHelper.typeCharacter): Escape backslash characters in order to build up
+        a well-formed UI script to evaluate.
+
 2018-09-06  Andy Estes  <aestes@apple.com>
 

trunk/LayoutTests/resources/ui-helper.js

@@ -312 +312 @@
         }
 
-        const escapedString = characterString.replace(/`/g, "\\`");
+        const escapedString = characterString.replace(/\\/g, "\\\\").replace(/`/g, "\\`");
         const uiScript = `uiController.typeCharacterUsingHardwareKeyboard(\`${escapedString}\`, () => uiController.uiScriptComplete())`;
         return new Promise(resolve => testRunner.runUIScript(uiScript, resolve));