Changeset 235825 in webkit

Timestamp:

Sep 7, 2018 5:41:14 PM (6 years ago)

Author:

Fujii Hironori

Message:

[Win][Clang] exceptionShouldTerminateProgram of StructuredExceptionHandlerSuppressor.cpp should take DWORD
​https://bugs.webkit.org/show_bug.cgi?id=189402

Reviewed by Alex Christensen.

Clang reports compilation errors like following:

StructuredExceptionHandlerSuppressor.cpp(38,10): error: case value evaluates to 2147483650, which cannot be narrowed to type 'int' [-Wc++11-narrowing]

case EXCEPTION_DATATYPE_MISALIGNMENT:

No new tests (no behavioral change).

• platform/win/StructuredExceptionHandlerSuppressor.cpp:

(exceptionShouldTerminateProgram): Changed the type of argument from int to DWORD.

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• platform/win/StructuredExceptionHandlerSuppressor.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2018-09-07  Fujii Hironori  <Hironori.Fujii@sony.com>
+
+        [Win][Clang] exceptionShouldTerminateProgram of StructuredExceptionHandlerSuppressor.cpp should take DWORD
+        https://bugs.webkit.org/show_bug.cgi?id=189402
+
+        Reviewed by Alex Christensen.
+
+        Clang reports compilation errors like following:
+
+        > StructuredExceptionHandlerSuppressor.cpp(38,10):  error: case value evaluates to 2147483650, which cannot be narrowed to type 'int' [-Wc++11-narrowing]
+        >     case EXCEPTION_DATATYPE_MISALIGNMENT:
+        >          ^
+
+        No new tests (no behavioral change).
+
+        * platform/win/StructuredExceptionHandlerSuppressor.cpp:
+        (exceptionShouldTerminateProgram): Changed the type of argument from int to DWORD.
+
 2018-09-07  Basuke Suzuki  <Basuke.Suzuki@sony.com>
 

trunk/Source/WebCore/platform/win/StructuredExceptionHandlerSuppressor.cpp

@@ -32 +32 @@
 #endif
 
-static bool exceptionShouldTerminateProgram(int code)
+static bool exceptionShouldTerminateProgram(DWORD code)
 {
     switch (code) {