Changeset 235855 in webkit

Timestamp:

Sep 10, 2018 12:39:10 PM (6 years ago)

Author:

fred.wang@free.fr

Message:

[CSSOM View] Handle the scrollingElement in Element::scroll(Left/Top/Width/Height/To)
​https://bugs.webkit.org/show_bug.cgi?id=182230

Follow-up patch replacing document.body with document.scrollingElement in
fast-scroll-iframe-latched-mainframe.html. This fixes flaky behavior.

Patch by Frederic Wang <​fwang@igalia.com> on 2018-09-10
Reviewed by Antonio Gomes.

• tiled-drawing/scrolling/fast-scroll-iframe-latched-mainframe.html: Replace document.body

with document.scrollingElement since this document is in standard mode.

Location:

trunk/LayoutTests

Files:

• ChangeLog (modified) (1 diff)
• tiled-drawing/scrolling/fast-scroll-iframe-latched-mainframe.html (modified) (3 diffs)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2018-09-10  Frederic Wang  <fwang@igalia.com>
+
+        [CSSOM View] Handle the scrollingElement in Element::scroll(Left/Top/Width/Height/To)
+        https://bugs.webkit.org/show_bug.cgi?id=182230
+
+        Follow-up patch replacing document.body with document.scrollingElement in
+        fast-scroll-iframe-latched-mainframe.html. This fixes flaky behavior.
+
+        Reviewed by Antonio Gomes.
+
+        * tiled-drawing/scrolling/fast-scroll-iframe-latched-mainframe.html: Replace document.body
+        with document.scrollingElement since this document is in standard mode.
+
 2018-09-10  Antoine Quint  <graouts@apple.com>
 

trunk/LayoutTests/tiled-drawing/scrolling/fast-scroll-iframe-latched-mainframe.html

@@ -20 +20 @@
 function onPageScroll()
 {
-    if (document.body.scrollTop >= 70)
+    if (document.scrollingElement.scrollTop >= 70)
         checkForScroll();
 }
@@ -27 +27 @@
 {
     // The IFrame should not have scrolled at all.
-    var pageScrollPositionAfter = document.body.scrollTop;
-    var iFrameScrollPositionAfter = window.frames['target'].document.body.scrollTop;
+    var pageScrollPositionAfter = document.scrollingElement.scrollTop;
+    var iFrameScrollPositionAfter = window.frames['target'].document.scrollingElement.scrollTop;
 
     if (iFrameScrollPositionBefore != iFrameScrollPositionAfter)
@@ -45 +45 @@
 function scrollTest()
 {
-    pageScrollPositionBefore = document.body.scrollTop;
-    iFrameScrollPositionBefore = window.frames['target'].document.body.scrollTop;
+    pageScrollPositionBefore = document.scrollingElement.scrollTop;
+    iFrameScrollPositionBefore = window.frames['target'].document.scrollingElement.scrollTop;
 
     iframeTarget = document.getElementById('target');