Changeset 236211 in webkit

Timestamp:

Sep 19, 2018 10:17:34 AM (6 years ago)

Author:

youenn@apple.com

Message:

Layout Test webrtc/video-mute.html is flaky.
​https://bugs.webkit.org/show_bug.cgi?id=177501

Reviewed by Eric Carlson.

Source/WebCore:

Covered by updated test expectation.

• platform/mediastream/mac/RealtimeIncomingVideoSourceCocoa.mm:

(WebCore::createBlackPixelBuffer): Make sure the whole buffer is properly initialized.

LayoutTests:

• platform/ios-wk2/TestExpectations:
• platform/mac-wk2/TestExpectations:
• webrtc/routines.js: Increase counter to make test more robust.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/platform/ios-wk2/TestExpectations (modified) (1 diff)
• LayoutTests/platform/mac-wk2/TestExpectations (modified) (1 diff)
• LayoutTests/webrtc/routines.js (modified) (1 diff)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/platform/mediastream/mac/RealtimeIncomingVideoSourceCocoa.mm (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2018-09-19  Youenn Fablet  <youenn@apple.com>
+
+        Layout Test webrtc/video-mute.html is flaky.
+        https://bugs.webkit.org/show_bug.cgi?id=177501
+
+        Reviewed by Eric Carlson.
+
+        * platform/ios-wk2/TestExpectations:
+        * platform/mac-wk2/TestExpectations:
+        * webrtc/routines.js: Increase counter to make test more robust.
+
 2018-09-19  Chris Dumez  <cdumez@apple.com>
 

trunk/LayoutTests/platform/ios-wk2/TestExpectations

@@ -1235 +1235 @@
 webkit.org/b/173608 webrtc/video-replace-muted-track.html [ Skip ]
 
-webkit.org/b/177501 webrtc/video-mute.html [ Pass Timeout ]
-
 webkit.org/b/187388 animations/needs-layout.html [ Pass ImageOnlyFailure ]
 webkit.org/b/172397 legacy-animation-engine/animations/needs-layout.html [ Pass ImageOnlyFailure ]

trunk/LayoutTests/platform/mac-wk2/TestExpectations

@@ -784 +784 @@
 webkit.org/b/178553 [ HighSierra Release ] imported/w3c/web-platform-tests/html/dom/dynamic-markup-insertion/opening-the-input-stream/011.html [ Skip ]
 
-webkit.org/b/177501 webrtc/video-mute.html [ Pass Timeout ]
-
 webkit.org/b/165620 [ Sierra ] http/tests/cache/disk-cache/disk-cache-request-headers.html [ Pass Failure ]
 

trunk/LayoutTests/webrtc/routines.js

@@ -196 +196 @@
     if (counter === undefined)
         counter = 0;
-    if (counter > 50) {
+    if (counter > 400) {
         if (!errorMessage)
             errorMessage = "checkVideoBlack timed out expecting " + expected;

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2018-09-19  Youenn Fablet  <youenn@apple.com>
+
+        Layout Test webrtc/video-mute.html is flaky.
+        https://bugs.webkit.org/show_bug.cgi?id=177501
+
+        Reviewed by Eric Carlson.
+
+        Covered by updated test expectation.
+
+        * platform/mediastream/mac/RealtimeIncomingVideoSourceCocoa.mm:
+        (WebCore::createBlackPixelBuffer): Make sure the whole buffer is properly initialized.
+
 2018-09-19  David Kilzer  <ddkilzer@apple.com>
 

trunk/Source/WebCore/platform/mediastream/mac/RealtimeIncomingVideoSourceCocoa.mm

@@ -74 +74 @@
     ASSERT(status == noErr);
     void* data = CVPixelBufferGetBaseAddress(pixelBuffer);
+
     size_t yLength = width * height;
     memset(data, 0, yLength);
-    memset(static_cast<uint8_t*>(data) + yLength, 128, yLength / 2);
+
+    auto totalSize = CVPixelBufferGetDataSize(pixelBuffer);
+    memset(static_cast<uint8_t*>(data) + yLength, 128, totalSize - yLength);
 
     status = CVPixelBufferUnlockBaseAddress(pixelBuffer, 0);