Changeset 236412 in webkit


Ignore:
Timestamp:
Sep 24, 2018 11:00:31 AM (6 years ago)
Author:
Simon Fraser
Message:

Garbled rendering of image when applied feConvolveMatrix to it, on Retina display
​https://bugs.webkit.org/show_bug.cgi?id=189748
<rdar://problem/44621494>

Reviewed by Jon Lee.
Source/WebCore:

feConvolveMatrix needs to scale the paintSize by the filter scale (2x on Retina displays),
otherwise parts of the output buffer are uninitialized and the result is incorrect.

Test: css3/filters/hidpi-feConvolveMatrix.html

  • platform/graphics/filters/FEConvolveMatrix.cpp:

(WebCore::FEConvolveMatrix::platformApplySoftware):

LayoutTests:

  • css3/filters/hidpi-feConvolveMatrix-expected.html: Added.
  • css3/filters/hidpi-feConvolveMatrix.html: Added.
Location:
trunk
Files:
2 added
3 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r236410 r236412  
     12018-09-24  Simon Fraser  <simon.fraser@apple.com>
     2
     3        Garbled rendering of image when applied feConvolveMatrix to it, on Retina display
     4        https://bugs.webkit.org/show_bug.cgi?id=189748
     5        <rdar://problem/44621494>
     6
     7        Reviewed by Jon Lee.
     8
     9        * css3/filters/hidpi-feConvolveMatrix-expected.html: Added.
     10        * css3/filters/hidpi-feConvolveMatrix.html: Added.
     11
    1122018-09-22  Dean Jackson  <dino@apple.com>
    213

  • trunk/Source/WebCore/ChangeLog

    r236410 r236412  
     12018-09-24  Simon Fraser  <simon.fraser@apple.com>
     2
     3        Garbled rendering of image when applied feConvolveMatrix to it, on Retina display
     4        https://bugs.webkit.org/show_bug.cgi?id=189748
     5        <rdar://problem/44621494>
     6
     7        Reviewed by Jon Lee.
     8       
     9        feConvolveMatrix needs to scale the paintSize by the filter scale (2x on Retina displays),
     10        otherwise parts of the output buffer are uninitialized and the result is incorrect.
     11
     12        Test: css3/filters/hidpi-feConvolveMatrix.html
     13
     14        * platform/graphics/filters/FEConvolveMatrix.cpp:
     15        (WebCore::FEConvolveMatrix::platformApplySoftware):
     16
    1172018-09-22  Dean Jackson  <dino@apple.com>
    218

  • trunk/Source/WebCore/platform/graphics/filters/FEConvolveMatrix.cpp

    r228218 r236412  
    392392
    393393    IntSize paintSize = absolutePaintRect().size();
     394    paintSize.scale(filter().filterScale());
     395
    394396    PaintingData paintingData = {
    395397        *srcPixelArray,
Note: See TracChangeset for help on using the changeset viewer.