Changeset 236755 in webkit


Ignore:
Timestamp:
Oct 2, 2018 11:39:08 AM (5 years ago)
Author:
realdawei@apple.com
Message:

Unreviewed, rolling out r236751.

broke the iOS Build

Reverted changeset:

"Fix iOS TestWebKitAPI failures following
<https://trac.webkit.org/changeset/236619>"
https://bugs.webkit.org/show_bug.cgi?id=190017
https://trac.webkit.org/changeset/236751

Patch by Dawei Fenton <realdawei@apple.com> on 2018-10-02

Location:
trunk/Tools
Files:
4 edited

Legend:

Unmodified
Added
Removed
  • trunk/Tools/ChangeLog

    r236751 r236755  
     12018-10-02  Dawei Fenton  <realdawei@apple.com>
     2
     3        Unreviewed, rolling out r236751.
     4
     5        broke the iOS Build
     6
     7        Reverted changeset:
     8
     9        "Fix iOS TestWebKitAPI failures following
     10        <https://trac.webkit.org/changeset/236619>"
     11        https://bugs.webkit.org/show_bug.cgi?id=190017
     12        https://trac.webkit.org/changeset/236751
     13
    1142018-10-02  Daniel Bates  <dabates@apple.com>
    215
  • trunk/Tools/TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm

    r236751 r236755  
    2828#if ENABLE(DRAG_SUPPORT) && PLATFORM(IOS) && WK_API_ENABLED
    2929
    30 #import "ClassMethodSwizzler.h"
    3130#import "DragAndDropSimulator.h"
    3231#import "PlatformUtilities.h"
     
    909908}
    910909
    911 static BOOL overrideIsInHardwareKeyboardMode()
    912 {
    913     return NO;
    914 }
    915 
    916910TEST(DragAndDropTests, ExternalSourceUTF8PlainTextOnly)
    917911{
    918     ClassMethodSwizzler swizzler([UIKeyboard class], @selector(isInHardwareKeyboardMode), reinterpret_cast<IMP>(overrideIsInHardwareKeyboardMode));
    919 
    920912    auto webView = adoptNS([[TestWKWebView alloc] initWithFrame:CGRectMake(0, 0, 320, 500)]);
    921913    [webView synchronouslyLoadTestPageNamed:@"autofocus-contenteditable"];
     
    937929TEST(DragAndDropTests, ExternalSourceJPEGOnly)
    938930{
    939     ClassMethodSwizzler swizzler([UIKeyboard class], @selector(isInHardwareKeyboardMode), reinterpret_cast<IMP>(overrideIsInHardwareKeyboardMode));
    940 
    941931    auto webView = adoptNS([[TestWKWebView alloc] initWithFrame:CGRectMake(0, 0, 320, 500)]);
    942932    [webView synchronouslyLoadTestPageNamed:@"autofocus-contenteditable"];
  • trunk/Tools/TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm

    r236751 r236755  
    2828#if WK_API_ENABLED && PLATFORM(IOS)
    2929
    30 #import "ClassMethodSwizzler.h"
    3130#import "PlatformUtilities.h"
    3231#import "TestInputDelegate.h"
     
    166165}
    167166
    168 static BOOL overrideIsInHardwareKeyboardMode()
    169 {
    170     return NO;
    171 }
    172 
    173167TEST(WKWebViewAutofillTests, AutofillRequiresInputSession)
    174168{
    175     ClassMethodSwizzler swizzler([UIKeyboard class], @selector(isInHardwareKeyboardMode), reinterpret_cast<IMP>(overrideIsInHardwareKeyboardMode));
    176 
    177169    auto webView = adoptNS([[AutofillTestView alloc] initWithFrame:CGRectMake(0, 0, 320, 500)]);
    178170    [(TestInputDelegate *)[webView _inputDelegate] setFocusStartsInputSessionPolicyHandler:[] (WKWebView *, id <_WKFocusedElementInfo>) -> _WKFocusStartsInputSessionPolicy {
  • trunk/Tools/TestWebKitAPI/ios/UIKitSPI.h

    r236751 r236755  
    3131
    3232#import <UIKit/UIApplication_Private.h>
    33 #import <UIKit/UIKeyboard_Private.h>
    3433#import <UIKit/UIResponder_Private.h>
    3534#import <UIKit/UITextInputMultiDocument.h>
     
    162161@end
    163162
    164 @interface UIKeyboard ()
    165 + (BOOL)isInHardwareKeyboardMode;
    166 @end
    167 
    168163#endif // PLATFORM(IOS)
Note: See TracChangeset for help on using the changeset viewer.