Changeset 237090 in webkit


Ignore:
Timestamp:
Oct 12, 2018 4:52:09 PM (5 years ago)
Author:
Devin Rousso
Message:

Web Inspector: Canvas: previews aren't removed when the parent view is hidden
https://bugs.webkit.org/show_bug.cgi?id=190525

Reviewed by Matt Baker.

  • UserInterface/Views/CanvasTabContentView.js:

(WI.CanvasTabContentView.prototype.attached):

  • UserInterface/Controllers/CanvasManager.js:

(WI.CanvasManager.prototype.get canvases):
(WI.CanvasManager.prototype.get shaderPrograms):
Drive-by: simplify these getters.

Location:
trunk/Source/WebInspectorUI
Files:
3 edited

Legend:

Unmodified
Added
Removed
  • trunk/Source/WebInspectorUI/ChangeLog

    r237085 r237090  
     12018-10-12  Devin Rousso  <drousso@apple.com>
     2
     3        Web Inspector: Canvas: previews aren't removed when the parent view is hidden
     4        https://bugs.webkit.org/show_bug.cgi?id=190525
     5
     6        Reviewed by Matt Baker.
     7
     8        * UserInterface/Views/CanvasTabContentView.js:
     9        (WI.CanvasTabContentView.prototype.attached):
     10
     11        * UserInterface/Controllers/CanvasManager.js:
     12        (WI.CanvasManager.prototype.get canvases):
     13        (WI.CanvasManager.prototype.get shaderPrograms):
     14        Drive-by: simplify these getters.
     15
    1162018-10-12  Joseph Pecoraro  <pecoraro@apple.com>
    217
  • trunk/Source/WebInspectorUI/UserInterface/Controllers/CanvasManager.js

    r237010 r237090  
    4343    get canvases()
    4444    {
    45         return [...this._canvasIdentifierMap.values()];
     45        return Array.from(this._canvasIdentifierMap.values());
    4646    }
    4747
    4848    get shaderPrograms()
    4949    {
    50         return [...this._shaderProgramIdentifierMap.values()];
     50        return Array.from(this._shaderProgramIdentifierMap.values());
    5151    }
    5252
  • trunk/Source/WebInspectorUI/UserInterface/Views/CanvasTabContentView.js

    r236952 r237090  
    128128        WI.Canvas.addEventListener(WI.Canvas.Event.RecordingStopped, this._recordingImportedOrStopped, this);
    129129
    130         let canvases = new Set([...this._canvasCollection, ...WI.canvasManager.canvases]);
     130        let canvases = WI.canvasManager.canvases;
    131131
    132132        for (let canvas of this._canvasCollection) {
    133             if (!canvases.has(canvas))
     133            if (!canvases.includes(canvas))
    134134                this._removeCanvas(canvas);
    135135        }
Note: See TracChangeset for help on using the changeset viewer.