Changeset 237090 in webkit
- Timestamp:
- Oct 12, 2018 4:52:09 PM (5 years ago)
- Location:
- trunk/Source/WebInspectorUI
- Files:
-
- 3 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/Source/WebInspectorUI/ChangeLog
r237085 r237090 1 2018-10-12 Devin Rousso <drousso@apple.com> 2 3 Web Inspector: Canvas: previews aren't removed when the parent view is hidden 4 https://bugs.webkit.org/show_bug.cgi?id=190525 5 6 Reviewed by Matt Baker. 7 8 * UserInterface/Views/CanvasTabContentView.js: 9 (WI.CanvasTabContentView.prototype.attached): 10 11 * UserInterface/Controllers/CanvasManager.js: 12 (WI.CanvasManager.prototype.get canvases): 13 (WI.CanvasManager.prototype.get shaderPrograms): 14 Drive-by: simplify these getters. 15 1 16 2018-10-12 Joseph Pecoraro <pecoraro@apple.com> 2 17 -
trunk/Source/WebInspectorUI/UserInterface/Controllers/CanvasManager.js
r237010 r237090 43 43 get canvases() 44 44 { 45 return [...this._canvasIdentifierMap.values()];45 return Array.from(this._canvasIdentifierMap.values()); 46 46 } 47 47 48 48 get shaderPrograms() 49 49 { 50 return [...this._shaderProgramIdentifierMap.values()];50 return Array.from(this._shaderProgramIdentifierMap.values()); 51 51 } 52 52 -
trunk/Source/WebInspectorUI/UserInterface/Views/CanvasTabContentView.js
r236952 r237090 128 128 WI.Canvas.addEventListener(WI.Canvas.Event.RecordingStopped, this._recordingImportedOrStopped, this); 129 129 130 let canvases = new Set([...this._canvasCollection, ...WI.canvasManager.canvases]);130 let canvases = WI.canvasManager.canvases; 131 131 132 132 for (let canvas of this._canvasCollection) { 133 if (!canvases. has(canvas))133 if (!canvases.includes(canvas)) 134 134 this._removeCanvas(canvas); 135 135 }
Note: See TracChangeset
for help on using the changeset viewer.