Changeset 237330 in webkit

Timestamp:

Oct 22, 2018 2:05:20 PM (6 years ago)

Author:

sihui_liu@apple.com

Message:

Regression (r232410): StorageTracker.db file gets unlinked while in use
​https://bugs.webkit.org/show_bug.cgi?id=190795

Reviewed by Chris Dumez.

WK2 stopped using StorageTracker.db file in r232410 and would delete
the file for safety.
It turned out WK1 could use the same file path, so WK2 may delete the
file while WK1 is using it.

• Storage/StorageTracker.cpp:

(WebKit::StorageTracker::trackerDatabasePath):

Location:

trunk/Source/WebKitLegacy

Files:

• ChangeLog (modified) (1 diff)
• Storage/StorageTracker.cpp (modified) (1 diff)

trunk/Source/WebKitLegacy/ChangeLog

@@ +1 @@
+2018-10-22  Sihui Liu  <sihui_liu@apple.com>
+
+        Regression (r232410): StorageTracker.db file gets unlinked while in use
+        https://bugs.webkit.org/show_bug.cgi?id=190795
+
+        Reviewed by Chris Dumez.
+
+        WK2 stopped using StorageTracker.db file in r232410 and would delete 
+        the file for safety.
+        It turned out WK1 could use the same file path, so WK2 may delete the 
+        file while WK1 is using it.
+
+        * Storage/StorageTracker.cpp:
+        (WebKit::StorageTracker::trackerDatabasePath):
+
 2018-10-18  Alexey Proskuryakov  <ap@apple.com>
 

trunk/Source/WebKitLegacy/Storage/StorageTracker.cpp

@@ -105 +105 @@
 {
     ASSERT(!m_databaseMutex.tryLock());
-    return FileSystem::pathByAppendingComponent(m_storageDirectoryPath, "StorageTracker.db");
+    return FileSystem::pathByAppendingComponent(m_storageDirectoryPath, "LegacyStorageTracker.db");
 }