Changeset 237381 in webkit

Timestamp:

Oct 24, 2018 7:15:15 AM (5 years ago)

Author:

aestes@apple.com

Message:

[macOS Debug WK2] Layout Test http/tests/ssl/applepay/ApplePayShippingAddressChangeEventErrorsV3.https.html is a flaky failure
​https://bugs.webkit.org/show_bug.cgi?id=190650
<rdar://problem/45341914>

Reviewed by Alex Christensen.

Source/WebCore:

In computeErrors, we intend to ignore errors when computing paymentMethodErrors. But we
weren't clearing exceptions generated from calling convert(), so they would end up being
logged as unhandled promise rejections.

Changed ApplePayPaymentHandler::computeErrors() to use a CatchScope to clear exceptions when
decoding paymentMethodErrors.

Also changed ApplePayShippingAddressChangeEventErrorsV3.https.html to catch promise
rejections from calling PaymentRequest.abort().

Covered by existing test.

• Modules/applepay/paymentrequest/ApplePayPaymentHandler.cpp:

(WebCore::ApplePayPaymentHandler::computeErrors const):

LayoutTests:

• http/tests/resources/payment-request.js:

(updateDetailsOnShippingAddressChange):

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/http/tests/resources/payment-request.js (modified) (1 diff)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/Modules/applepay/paymentrequest/ApplePayPaymentHandler.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2018-10-24  Andy Estes  <aestes@apple.com>
+
+        [macOS Debug WK2] Layout Test http/tests/ssl/applepay/ApplePayShippingAddressChangeEventErrorsV3.https.html is a flaky failure
+        https://bugs.webkit.org/show_bug.cgi?id=190650
+        <rdar://problem/45341914>
+
+        Reviewed by Alex Christensen.
+
+        * http/tests/resources/payment-request.js:
+        (updateDetailsOnShippingAddressChange):
+
 2018-10-23  Jer Noble  <jer.noble@apple.com>
 

trunk/LayoutTests/http/tests/resources/payment-request.js

@@ -69 +69 @@
                 detailsUpdatePromise.then(() => {
                     resolve();
-                    request.abort();
+                    request.abort().catch(() => { });
                 });
             };

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2018-10-24  Andy Estes  <aestes@apple.com>
+
+        [macOS Debug WK2] Layout Test http/tests/ssl/applepay/ApplePayShippingAddressChangeEventErrorsV3.https.html is a flaky failure
+        https://bugs.webkit.org/show_bug.cgi?id=190650
+        <rdar://problem/45341914>
+
+        Reviewed by Alex Christensen.
+
+        In computeErrors, we intend to ignore errors when computing paymentMethodErrors. But we
+        weren't clearing exceptions generated from calling convert(), so they would end up being
+        logged as unhandled promise rejections.
+
+        Changed ApplePayPaymentHandler::computeErrors() to use a CatchScope to clear exceptions when
+        decoding paymentMethodErrors.
+
+        Also changed ApplePayShippingAddressChangeEventErrorsV3.https.html to catch promise
+        rejections from calling PaymentRequest.abort().
+
+        Covered by existing test.
+
+        * Modules/applepay/paymentrequest/ApplePayPaymentHandler.cpp:
+        (WebCore::ApplePayPaymentHandler::computeErrors const):
+
 2018-10-22  Antti Koivisto  <antti@apple.com>
 

trunk/Source/WebCore/Modules/applepay/paymentrequest/ApplePayPaymentHandler.cpp

@@ -364 +364 @@
     if (paymentMethodErrors) {
         auto& context = *scriptExecutionContext();
-        auto throwScope = DECLARE_THROW_SCOPE(context.vm());
+        auto catchScope = DECLARE_CATCH_SCOPE(context.vm());
         auto applePayErrors = convert<IDLSequence<IDLInterface<ApplePayError>>>(*context.execState(), paymentMethodErrors);
-        if (!throwScope.exception()) {
+        if (!catchScope.exception()) {
             for (auto& applePayError : applePayErrors) {
                 if (applePayError)
                     errors.append({ applePayError->code(), applePayError->message(), applePayError->contactField() });
             }
-        }
+        } else
+            catchScope.clearException();
     }
 #else