Changeset 237384 in webkit

Timestamp:

Oct 24, 2018 8:38:26 AM (5 years ago)

Author:

Chris Dumez

Message:

REGRESSION (r237257): [iOS] Crashes in com.apple.WebKit: WebKit::RemoteScrollingCoordinator::scheduleTreeStateCommit
​https://bugs.webkit.org/show_bug.cgi?id=190804

Reviewed by Alex Christensen.

Fix null-dereference of the drawing area in RemoteScrollingCoordinator::scheduleTreeStateCommit.
With process-swap-on-navigation enabled, suspended pages' drawing area gets torn down.

• WebProcess/WebPage/RemoteLayerTree/RemoteScrollingCoordinator.mm:

(WebKit::RemoteScrollingCoordinator::scheduleTreeStateCommit):

Location:

trunk/Source/WebKit

Files:

• ChangeLog (modified) (1 diff)
• WebProcess/WebPage/RemoteLayerTree/RemoteScrollingCoordinator.mm (modified) (1 diff)

trunk/Source/WebKit/ChangeLog

@@ +1 @@
+2018-10-24  Chris Dumez  <cdumez@apple.com>
+
+        REGRESSION (r237257): [iOS] Crashes in com.apple.WebKit: WebKit::RemoteScrollingCoordinator::scheduleTreeStateCommit
+        https://bugs.webkit.org/show_bug.cgi?id=190804
+
+        Reviewed by Alex Christensen.
+
+        Fix null-dereference of the drawing area in RemoteScrollingCoordinator::scheduleTreeStateCommit.
+        With process-swap-on-navigation enabled, suspended pages' drawing area gets torn down.
+
+        * WebProcess/WebPage/RemoteLayerTree/RemoteScrollingCoordinator.mm:
+        (WebKit::RemoteScrollingCoordinator::scheduleTreeStateCommit):
+
 2018-10-24  Claudio Saavedra  <csaavedra@igalia.com>
 

trunk/Source/WebKit/WebProcess/WebPage/RemoteLayerTree/RemoteScrollingCoordinator.mm

@@ -62 +62 @@
 void RemoteScrollingCoordinator::scheduleTreeStateCommit()
 {
-    m_webPage->drawingArea()->scheduleCompositingLayerFlush();
+    if (auto* drawingArea = m_webPage->drawingArea())
+        drawingArea->scheduleCompositingLayerFlush();
 }