Changeset 237411 in webkit

Timestamp:

Oct 25, 2018 5:46:28 AM (6 years ago)

Author:

fred.wang@free.fr

Message:

Add more tests for the Find UI
​https://bugs.webkit.org/show_bug.cgi?id=190823

Patch by Frederic Wang <​fwang@igalia.com> on 2018-10-25
Reviewed by Antonio Gomes.

We add more tests for iOS's find UI to cover cases fixed by r224284. Equivalent tests for
subframes currently fails when frame flattening is disabled, they will be handled in bug
184297.

• platform/ios/fast/scrolling/find-text-in-overflow-node-indicator-position-expected.png: Added.
• platform/ios/fast/scrolling/find-text-in-overflow-node-indicator-position-expected.txt: Added.
• platform/ios/fast/scrolling/find-text-in-overflow-node-indicator-position-limit-expected.png: Added.
• platform/ios/fast/scrolling/find-text-in-overflow-node-indicator-position-limit-expected.txt: Added.
• platform/ios/fast/scrolling/find-text-in-overflow-node-indicator-position-limit.html: Added.

Test with a match at the limit of the scrolling element.

• platform/ios/fast/scrolling/find-text-in-overflow-node-indicator-position.html: Added. Test

with a match at the middle of the scrolling element.

• platform/ios/fast/scrolling/find-text-in-overflow-node.html: Use names for parameters to

make it more explicit.

• platform/ios/fast/scrolling/find-text-in-subframe-expected.txt: Added.
• platform/ios/fast/scrolling/find-text-in-subframe.html: Added. Test with a subframe instead

of an overflow node.

Location:

trunk/LayoutTests

Files:

• ChangeLog (modified) (1 diff)
• platform/ios/fast/scrolling/find-text-in-overflow-node-indicator-position-expected.png (added)
• platform/ios/fast/scrolling/find-text-in-overflow-node-indicator-position-expected.txt (added)
• platform/ios/fast/scrolling/find-text-in-overflow-node-indicator-position-limit-expected.png (added)
• platform/ios/fast/scrolling/find-text-in-overflow-node-indicator-position-limit-expected.txt (added)
• platform/ios/fast/scrolling/find-text-in-overflow-node-indicator-position-limit.html (added)
• platform/ios/fast/scrolling/find-text-in-overflow-node-indicator-position.html (added)
• platform/ios/fast/scrolling/find-text-in-overflow-node.html (modified) (2 diffs)
• platform/ios/fast/scrolling/find-text-in-subframe-expected.txt (added)
• platform/ios/fast/scrolling/find-text-in-subframe.html (added)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2018-10-25  Frederic Wang  <fwang@igalia.com>
+
+        Add more tests for the Find UI
+        https://bugs.webkit.org/show_bug.cgi?id=190823
+
+        Reviewed by Antonio Gomes.
+
+        We add more tests for iOS's find UI to cover cases fixed by r224284. Equivalent tests for
+        subframes currently fails when frame flattening is disabled, they will be handled in bug
+        184297.
+
+        * platform/ios/fast/scrolling/find-text-in-overflow-node-indicator-position-expected.png: Added.
+        * platform/ios/fast/scrolling/find-text-in-overflow-node-indicator-position-expected.txt: Added.
+        * platform/ios/fast/scrolling/find-text-in-overflow-node-indicator-position-limit-expected.png: Added.
+        * platform/ios/fast/scrolling/find-text-in-overflow-node-indicator-position-limit-expected.txt: Added.
+        * platform/ios/fast/scrolling/find-text-in-overflow-node-indicator-position-limit.html: Added.
+        Test with a match at the limit of the scrolling element.
+        * platform/ios/fast/scrolling/find-text-in-overflow-node-indicator-position.html: Added. Test
+        with a match at the middle of the scrolling element.
+        * platform/ios/fast/scrolling/find-text-in-overflow-node.html: Use names for parameters to
+        make it more explicit.
+        * platform/ios/fast/scrolling/find-text-in-subframe-expected.txt: Added.
+        * platform/ios/fast/scrolling/find-text-in-subframe.html: Added. Test with a subframe instead
+        of an overflow node.
+
 2018-10-25  Jiewen Tan  <jiewen_tan@apple.com>
 

trunk/LayoutTests/platform/ios/fast/scrolling/find-text-in-overflow-node.html

@@ -15 +15 @@
           return;
 
+        var findOptions = 1 << 6; // show find indicator
+        var maxCount = 4;
         var node = document.getElementById("scrollable");
         test(function() {
@@ -22 +24 @@
         var afterMatch4 = async_test("Position of overflow node after the fourth result");
         testRunner.runUIScript(`
-          uiController.findString("match", 0, 4); // match
-          uiController.findString("match", 0, 4); // match 2
-          uiController.findString("match", 0, 4); // match 3
+          uiController.findString("match", ${findOptions}, ${maxCount}); // match
+          uiController.findString("match", ${findOptions}, ${maxCount}); // match 2
+          uiController.findString("match", ${findOptions}, ${maxCount}); // match 3
           uiController.uiScriptComplete("Done");
         `, afterMatch3.step_func_done(function() {
           assert_equals(node.scrollTop, 0);
           testRunner.runUIScript(`
-            uiController.findString("match", 0, 4); // match 4
+            uiController.findString("match", ${findOptions}, ${maxCount}); // match 4
             uiController.uiScriptComplete("Done");
           `, afterMatch4.step_func_done(function() {