Changeset 237413 in webkit

Timestamp:

Oct 25, 2018 7:15:21 AM (5 years ago)

Author:

Chris Dumez

Message:

REGRESSION (236779) scandinaviandesigns.com product pages auto redirect to product image
​https://bugs.webkit.org/show_bug.cgi?id=190891
<rdar://problem/45296796>

Reviewed by Antti Koivisto.

Source/WebCore:

When a radio element gets clicked, we should only fire the 'input' and 'change' if the checked state
of the radio element has changed.

Test: fast/dom/HTMLInputElement/radio-element-fires-change-event-only-when-checked-state-changes.html

• html/RadioInputType.cpp:

(WebCore::RadioInputType::didDispatchClick):

LayoutTests:

Add layout test coverage.

• fast/dom/HTMLInputElement/radio-element-fires-change-event-only-when-checked-state-changes-expected.txt: Added.
• fast/dom/HTMLInputElement/radio-element-fires-change-event-only-when-checked-state-changes.html: Added.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/fast/dom/HTMLInputElement/radio-element-fires-change-event-only-when-checked-state-changes-expected.txt (added)
• LayoutTests/fast/dom/HTMLInputElement/radio-element-fires-change-event-only-when-checked-state-changes.html (added)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/html/RadioInputType.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2018-10-25  Chris Dumez  <cdumez@apple.com>
+
+        REGRESSION (236779) scandinaviandesigns.com product pages auto redirect to product image
+        https://bugs.webkit.org/show_bug.cgi?id=190891
+        <rdar://problem/45296796>
+
+        Reviewed by Antti Koivisto.
+
+        Add layout test coverage.
+
+        * fast/dom/HTMLInputElement/radio-element-fires-change-event-only-when-checked-state-changes-expected.txt: Added.
+        * fast/dom/HTMLInputElement/radio-element-fires-change-event-only-when-checked-state-changes.html: Added.
+
 2018-10-25  Frederic Wang  <fwang@igalia.com>
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2018-10-25  Chris Dumez  <cdumez@apple.com>
+
+        REGRESSION (236779) scandinaviandesigns.com product pages auto redirect to product image
+        https://bugs.webkit.org/show_bug.cgi?id=190891
+        <rdar://problem/45296796>
+
+        Reviewed by Antti Koivisto.
+
+        When a radio element gets clicked, we should only fire the 'input' and 'change' if the checked state
+        of the radio element has changed.
+
+        Test: fast/dom/HTMLInputElement/radio-element-fires-change-event-only-when-checked-state-changes.html
+
+        * html/RadioInputType.cpp:
+        (WebCore::RadioInputType::didDispatchClick):
+
 2018-10-25  Joseph Pecoraro  <pecoraro@apple.com>
 

trunk/Source/WebCore/html/RadioInputType.cpp

@@ -170 +170 @@
         if (button && button->isRadioButton() && button->form() == element()->form() && button->name() == element()->name())
             button->setChecked(true);
-    } else
+    } else if (state.checked != element()->checked())
         fireInputAndChangeEvents();