Changeset 237422 in webkit

Timestamp:

Oct 25, 2018 12:51:42 PM (5 years ago)

Author:

commit-queue@webkit.org

Message:

Web Inspector: Add a watchlist message rule to warn about feature checking new inspector protocol changes
​https://bugs.webkit.org/show_bug.cgi?id=190896

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2018-10-25
Reviewed by Matt Baker.

• Scripts/webkitpy/common/config/watchlist:

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• Scripts/webkitpy/common/config/watchlist (modified) (2 diffs)

trunk/Tools/ChangeLog

@@ +1 @@
+2018-10-25  Joseph Pecoraro  <pecoraro@apple.com>
+
+        Web Inspector: Add a watchlist message rule to warn about feature checking new inspector protocol changes
+        https://bugs.webkit.org/show_bug.cgi?id=190896
+
+        Reviewed by Matt Baker.
+
+        * Scripts/webkitpy/common/config/watchlist:
+
 2018-10-25  Geoffrey Garen  <ggaren@apple.com>
 

trunk/Tools/Scripts/webkitpy/common/config/watchlist

@@ -192 +192 @@
                         r"|Tools/Scripts/webkitpy/inspector",
         },
+        "WebInspectorProtocol": {
+            "filename": r"Source/JavaScriptCore/inspector/protocol/",
+        },
         "WebInspectorRecording": {
-            "filename": r"Source/JavaScriptCore/inspector/Protocol/Recording\.json"
+            "filename": r"Source/JavaScriptCore/inspector/protocol/Recording\.json"
                         r"|Source/WebCore/bindings/js/CallTracer.*"
                         r"|Source/WebCore/inspector/Recording.*"
@@ -440 +443 @@
         "ANGLE": [ "Note that there are important steps to take when updating ANGLE. "
                    "See http://trac.webkit.org/wiki/UpdatingANGLE", ],
+        "WebInspectorProtocol": [ "This patch modifies the inspector protocol. Please ensure that any frontend changes appropriately use feature checks for new protocol features." ],
         "WebInspectorGenerator": [ "This patch modifies the inspector protocol generator. Please ensure that you have rebaselined any generator test results (i.e., by running `Tools/Scripts/run-inspector-generator-tests --reset-results`)" ],
         "JSBuiltinsGenerator": [ "This patch modifies the JS builtins code generator. Please ensure that you have rebaselined any generator test results (i.e., by running `Tools/Scripts/run-builtins-generator-tests --reset-results`)" ],