Changeset 237430 in webkit

Timestamp:

Oct 25, 2018 3:57:45 PM (5 years ago)

Author:

Devin Rousso

Message:

Web Inspector: Network: more aggressively snap timing blocks together
​https://bugs.webkit.org/show_bug.cgi?id=190439

Reviewed by Timothy Hatcher.

• UserInterface/Views/NetworkTableContentView.js:

(WI.NetworkTableContentView.prototype._populateWaterfallGraph.appendBlock):
(WI.NetworkTableContentView.prototype._populateWaterfallGraph):
If the time difference between the end of the previous block and the start of this block
would result in less than 2px of space, extend the next block back to the previous block.

Location:

trunk/Source/WebInspectorUI

Files:

• ChangeLog (modified) (1 diff)
• UserInterface/Views/NetworkTableContentView.js (modified) (1 diff)

trunk/Source/WebInspectorUI/ChangeLog

@@ +1 @@
+2018-10-25  Devin Rousso  <drousso@apple.com>
+
+        Web Inspector: Network: more aggressively snap timing blocks together
+        https://bugs.webkit.org/show_bug.cgi?id=190439
+
+        Reviewed by Timothy Hatcher.
+
+        * UserInterface/Views/NetworkTableContentView.js:
+        (WI.NetworkTableContentView.prototype._populateWaterfallGraph.appendBlock):
+        (WI.NetworkTableContentView.prototype._populateWaterfallGraph):
+        If the time difference between the end of the previous block and the start of this block
+        would result in less than 2px of space, extend the next block back to the previous block.
+
 2018-10-24  Devin Rousso  <drousso@apple.com>
 

trunk/Source/WebInspectorUI/UserInterface/Views/NetworkTableContentView.js

@@ -745 +745 @@
         }
 
+        let lastEndTimestamp = NaN;
         function appendBlock(startTimestamp, endTimestamp, className) {
             if (isNaN(startTimestamp) || isNaN(endTimestamp) || endTimestamp - startTimestamp <= 0)
                 return null;
+
+            if (Math.abs(startTimestamp - lastEndTimestamp) < secondsPerPixel * 2)
+                startTimestamp = lastEndTimestamp;
+            lastEndTimestamp = endTimestamp;
 
             let block = container.appendChild(document.createElement("div"));